fix global setting and check env vars once on init

Author: naji247

src/mcpcat/__init__.py

@@ -11,7 +11,7 @@
 
 from .modules.compatibility import is_compatible_server, is_fastmcp_server
 from .modules.internal import set_server_tracking_data
-from .modules.logging import write_to_log, debug_mode
+from .modules.logging import write_to_log, set_debug_mode
 from .types import (
     MCPCatData,
     MCPCatOptions,
@@ -44,7 +44,7 @@ def track(
         options = MCPCatOptions()
 
     # Update global debug_mode value
-    debug_mode = options.debug_mode
+    set_debug_mode(options.debug_mode)
 
     # Validate configuration
     if not project_id and not options.exporters:

src/mcpcat/modules/logging.py

@@ -6,7 +6,18 @@
 from mcpcat.types import MCPCatOptions
 
 
-debug_mode = False
+# Initialize debug_mode from environment variable at module load time
+_env_debug = os.getenv("MCPCAT_DEBUG_MODE")
+if _env_debug is not None:
+    debug_mode = _env_debug.lower() in ("true", "1", "yes", "on")
+else:
+    debug_mode = False
+
+
+def set_debug_mode(value: bool) -> None:
+    """Set the global debug_mode value."""
+    global debug_mode
+    debug_mode = value
 
 
 def write_to_log(message: str) -> None:
@@ -17,13 +28,7 @@ def write_to_log(message: str) -> None:
     log_path = os.path.expanduser("~/mcpcat.log")
 
     try:
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
-        if debug_mode == "true":
+        if debug_mode:
             # Write to log file (no need to ensure directory exists for home directory)
             with open(log_path, "a") as f:
                 f.write(log_entry)

tests/test_logging.py

@@ -8,7 +8,7 @@
 
 import pytest
 
-from mcpcat.modules.logging import write_to_log, debug_mode
+from mcpcat.modules.logging import write_to_log, set_debug_mode
 
 
 class TestLogging:
@@ -31,14 +31,8 @@ def cleanup_log_file(self):
 
     def test_write_to_log_creates_file(self, tmp_path):
         """Test that write_to_log creates the log file if it doesn't exist."""
-        # Enable debug mode using environment variable MCPCAT_DEBUG_MODE
-        os.environ["MCPCAT_DEBUG_MODE"] = "true"
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
+        # Enable debug mode
+        set_debug_mode(True)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -66,17 +60,8 @@ def test_write_to_log_creates_file(self, tmp_path):
 
     def test_write_to_log_checks_debug_mode(self, tmp_path):
         """Test that write_to_log writes to file when debug mode is enabled."""
-        # Check that MCPCAT_DEBUG_MODE overrides the default setting and writes log to file
-        os.environ["MCPCAT_DEBUG_MODE"] = "true"
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
-        assert debug_mode == "true", (
-            "Environment variable failed to override default setting"
-        )
+        # Enable debug mode
+        set_debug_mode(True)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -103,12 +88,7 @@ def test_write_to_log_checks_debug_mode(self, tmp_path):
             assert "T" in content, "Timestamp not in ISO format"
 
         # Check that log file is not created when debug mode is disabled
-        os.environ["MCPCAT_DEBUG_MODE"] = "false"
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
+        set_debug_mode(False)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -127,14 +107,8 @@ def test_write_to_log_checks_debug_mode(self, tmp_path):
 
     def test_write_to_log_appends_messages(self, tmp_path):
         """Test that write_to_log appends to existing log file."""
-        # Enable debug mode using environment variable MCPCAT_DEBUG_MODE
-        os.environ["MCPCAT_DEBUG_MODE"] = "true"
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
+        # Enable debug mode
+        set_debug_mode(True)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -184,14 +158,8 @@ def test_write_to_log_appends_messages(self, tmp_path):
 
     def test_write_to_log_handles_directory_creation(self, tmp_path):
         """Test that write_to_log creates parent directories if needed."""
-        # Enable debug mode using environment variable MCPCAT_DEBUG_MODE
-        os.environ["MCPCAT_DEBUG_MODE"] = "true"
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
+        # Enable debug mode
+        set_debug_mode(True)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -211,14 +179,8 @@ def test_write_to_log_handles_directory_creation(self, tmp_path):
 
     def test_write_to_log_silently_handles_errors(self, tmp_path, monkeypatch):
         """Test that write_to_log doesn't raise exceptions on errors."""
-        # Enable debug mode using environment variable MCPCAT_DEBUG_MODE
-        os.environ["MCPCAT_DEBUG_MODE"] = "true"
-        global debug_mode
-        debug_mode = (
-            os.getenv("MCPCAT_DEBUG_MODE").lower()
-            if os.getenv("MCPCAT_DEBUG_MODE") != None
-            else str(debug_mode).lower()
-        )
+        # Enable debug mode
+        set_debug_mode(True)
 
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
@@ -243,6 +205,9 @@ def test_write_to_log_silently_handles_errors(self, tmp_path, monkeypatch):
 
     def test_log_format(self, tmp_path):
         """Test the format of log entries."""
+        # Enable debug mode
+        set_debug_mode(True)
+        
         # Use a unique file name for this test
         unique_id = str(uuid.uuid4())
         log_file = tmp_path / f"test_mcpcat_{unique_id}.log"