Skip to content

Commit 961a7d9

Browse files
Merge pull request #160 from MihaiCristianCondrea/codex/fix-build-warnings-and-errors
Fix Data Binding ID Collisions in Onboarding Layouts
2 parents ce32cf5 + 3a2bc57 commit 961a7d9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

app/src/main/res/layout/fragment_onboarding_selection.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
android:padding="24dp">
5656

5757
<com.google.android.material.textview.MaterialTextView
58-
android:id="@+id/title"
58+
android:id="@+id/title_text"
5959
android:layout_width="0dp"
6060
android:layout_height="wrap_content"
6161
android:layout_marginTop="32dp"
@@ -67,7 +67,7 @@
6767
app:layout_constraintTop_toTopOf="parent" />
6868

6969
<com.google.android.material.textview.MaterialTextView
70-
android:id="@+id/description"
70+
android:id="@+id/description_text"
7171
android:layout_width="0dp"
7272
android:layout_height="wrap_content"
7373
android:layout_marginTop="8dp"
@@ -77,7 +77,7 @@
7777
android:textColor="?attr/colorOnSurfaceVariant"
7878
app:layout_constraintEnd_toEndOf="parent"
7979
app:layout_constraintStart_toStartOf="parent"
80-
app:layout_constraintTop_toBottomOf="@id/title" />
80+
app:layout_constraintTop_toBottomOf="@id/title_text" />
8181

8282
<androidx.constraintlayout.widget.ConstraintLayout
8383
android:id="@+id/selection_group"
@@ -87,7 +87,7 @@
8787
app:layout_constraintBottom_toBottomOf="parent"
8888
app:layout_constraintEnd_toEndOf="parent"
8989
app:layout_constraintStart_toStartOf="parent"
90-
app:layout_constraintTop_toBottomOf="@id/description">
90+
app:layout_constraintTop_toBottomOf="@id/description_text">
9191

9292
<RadioGroup
9393
android:id="@+id/option_group"

app/src/main/res/layout/item_onboarding_option.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
android:padding="12dp">
1515

1616
<androidx.appcompat.widget.AppCompatImageView
17-
android:id="@+id/icon"
17+
android:id="@+id/icon_view"
1818
android:layout_width="24dp"
1919
android:layout_height="24dp"
2020
android:src="@{icon}"
@@ -34,7 +34,7 @@
3434
android:textAppearance="?attr/textAppearanceTitleMedium"
3535
android:breakStrategy="balanced"
3636
android:hyphenationFrequency="none"
37-
app:layout_constraintStart_toEndOf="@id/icon"
37+
app:layout_constraintStart_toEndOf="@id/icon_view"
3838
app:layout_constraintTop_toTopOf="parent"
3939
app:layout_constraintEnd_toStartOf="@id/radio_button"
4040
tools:text="Light mode"/>

0 commit comments

Comments
 (0)