Merge pull request #193 from MixinNetwork/fix_send_tx_with_output_panic

cedricfung · web-flow · commit 46a3419d4f6b · 2024-09-02T01:56:32.000+04:00
fix sub might cause panic
diff --git a/transaction.go b/transaction.go
@@ -183,14 +183,14 @@ func SendTransactionWithOutputs(ctx context.Context, assetId string, recipients
 		amt := common.NewIntegerFromString(in.Amount)
 		totalInput = totalInput.Add(amt)
 	}
-	changeAmount := totalInput.Sub(totalOutput)
-	if changeAmount.Sign() < 0 {
+	if totalInput.Cmp(totalOutput) < 0 {
 		return nil, &UtxoInsufficientError{
 			TotalInput:  totalInput,
 			TotalOutput: totalOutput,
 			OutputSize:  1,
 		}
 	}
+	changeAmount := totalInput.Sub(totalOutput)
 	if changeAmount.Sign() > 0 {
 		ma := NewUUIDMixAddress([]string{u.UserId}, 1)
 		recipients = append(recipients, &TransactionRecipient{

Original file line number	Diff line number	Diff line change
`@@ -183,14 +183,14 @@ func SendTransactionWithOutputs(ctx context.Context, assetId string, recipients`
`183`	`183`	`amt := common.NewIntegerFromString(in.Amount)`
`184`	`184`	`totalInput = totalInput.Add(amt)`
`185`	`185`	`}`
`186`		`- changeAmount := totalInput.Sub(totalOutput)`
`187`		`- if changeAmount.Sign() < 0 {`
	`186`	`+ if totalInput.Cmp(totalOutput) < 0 {`
`188`	`187`	`return nil, &UtxoInsufficientError{`
`189`	`188`	`TotalInput: totalInput,`
`190`	`189`	`TotalOutput: totalOutput,`
`191`	`190`	`OutputSize: 1,`
`192`	`191`	`}`
`193`	`192`	`}`
	`193`	`+ changeAmount := totalInput.Sub(totalOutput)`
`194`	`194`	`if changeAmount.Sign() > 0 {`
`195`	`195`	`ma := NewUUIDMixAddress([]string{u.UserId}, 1)`
`196`	`196`	`recipients = append(recipients, &TransactionRecipient{`