Skip to content

Commit 1b578a5

Browse files
MusholicMusholic
committed
Support for mods with "Chance to cast ... when" like Decimate
1 parent e40cab5 commit 1b578a5

File tree

6 files changed

+237
-205
lines changed

6 files changed

+237
-205
lines changed

‎spec/System/TestModParse_spec.lua‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,4 +191,12 @@ describe("TestModParse", function()
191191

192192
assert.are.equals(17, build.configTab.modList:Sum("BASE", {flags = ModFlag.Hit}, "ChanceToTriggerOnHit_Ailment_Bleed"))
193193
end)
194+
195+
it("decimate cast chance", function()
196+
build.configTab.input.customMods = "17% Chance to cast Decimate when you directly use a Fire Spell (4 second cooldown)"
197+
build.configTab:BuildModList()
198+
runCallback("OnFrame")
199+
200+
assert.are.equals(17, build.configTab.modList:Sum("BASE", {keywordFlags = KeywordFlag.Fire}, "ChanceToTriggerOnHit_GasparSetSwipe"))
201+
end)
194202
end)

‎spec/TestBuilds/1.2/warpath_channel.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ return {
166166
["FistOfWarHitEffect"] = 1,
167167
["FrostShieldDamageMitigation"] = 0,
168168
["FrostShieldLife"] = 0,
169-
["FullDPS"] = 8730.4421,
169+
["FullDPS"] = 8795.7605,
170170
["FullLifePercentage"] = 100,
171171
["HitChance"] = 100,
172172
["IgniteAvoidChance"] = 0,

‎spec/TestBuilds/1.2/warpath_channel.xml‎

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,14 @@
6161
<PlayerStat stat="VoidResist" value="75"></PlayerStat>
6262
<PlayerStat stat="VoidResistOverCap" value="1"></PlayerStat>
6363
<PlayerStat stat="EffectiveMovementSpeedMod" value="1.56"></PlayerStat>
64-
<PlayerStat stat="FullDPS" value="8730.4420627375"></PlayerStat>
64+
<PlayerStat stat="FullDPS" value="8795.7605396747"></PlayerStat>
6565
<FullDPSSkill skillPart="" source="" stat="Smite" value="7846.0256559886"></FullDPSSkill>
6666
<FullDPSSkill skillPart="" source="Smite" stat="Ignite" value="826.61037795706"></FullDPSSkill>
67-
<FullDPSSkill skillPart="" source="Smite" stat="Electrify" value="57.806028791839"></FullDPSSkill>
67+
<FullDPSSkill skillPart="" source="Smite" stat="Electrify" value="58.125399116656"></FullDPSSkill>
68+
<FullDPSSkill skillPart="" source="Smite" stat="Axe Throw" value="43.881438095962"></FullDPSSkill>
69+
<FullDPSSkill skillPart="" source="AxeThrow" stat="Ignite" value="18.893951496161"></FullDPSSkill>
70+
<FullDPSSkill skillPart="" source="AxeThrow" stat="Electrify" value="1.3285271645726"></FullDPSSkill>
71+
<FullDPSSkill skillPart="" source="AxeThrow" stat="Axe Throw" value="0.89518985559494"></FullDPSSkill>
6872
</Build>
6973
<Calcs>
7074
<Input name="misc_buffMode" string="EFFECTIVE"></Input>
@@ -842,19 +846,31 @@ Implicits: 1
842846
<Skill enabled="true" includeInFullDPS="true" index="8" label="Electrify (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Smite"></Skill>
843847
<Skill enabled="true" includeInFullDPS="true" index="9" label="Ignite (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Smite"></Skill>
844848
<Skill enabled="true" includeInFullDPS="true" index="10" label="Shock (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Smite"></Skill>
845-
<Skill enabled="true" includeInFullDPS="false" index="11" label="Shred Armor (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Warpath"></Skill>
846-
<Skill enabled="true" includeInFullDPS="false" index="12" label="Bleed (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Warpath"></Skill>
847-
<Skill enabled="true" includeInFullDPS="false" index="13" label="Blind (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Warpath"></Skill>
848-
<Skill enabled="true" includeInFullDPS="false" index="14" label="Electrify (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Warpath"></Skill>
849-
<Skill enabled="true" includeInFullDPS="false" index="15" label="Shock (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Warpath"></Skill>
850-
<Skill enabled="true" includeInFullDPS="false" index="16" label="Shred Armor (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Javelin"></Skill>
851-
<Skill enabled="true" includeInFullDPS="false" index="17" label="Bleed (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Javelin"></Skill>
852-
<Skill enabled="true" includeInFullDPS="false" index="18" label="Blind (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Javelin"></Skill>
853-
<Skill enabled="true" includeInFullDPS="false" index="19" label="Electrify (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Javelin"></Skill>
854-
<Skill enabled="true" includeInFullDPS="false" index="20" label="Frailty (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:Javelin"></Skill>
855-
<Skill enabled="true" includeInFullDPS="false" index="21" label="Ignite (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Javelin"></Skill>
856-
<Skill enabled="true" includeInFullDPS="false" index="22" label="Shock (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Javelin"></Skill>
857-
<Skill enabled="true" includeInFullDPS="false" index="23" label="Slow (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:Javelin"></Skill>
849+
<Skill enabled="true" includeInFullDPS="true" index="11" label="Axe Throw (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Smite"></Skill>
850+
<Skill enabled="true" includeInFullDPS="false" index="12" label="Shred Armor (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Warpath"></Skill>
851+
<Skill enabled="true" includeInFullDPS="false" index="13" label="Bleed (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Warpath"></Skill>
852+
<Skill enabled="true" includeInFullDPS="false" index="14" label="Blind (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Warpath"></Skill>
853+
<Skill enabled="true" includeInFullDPS="false" index="15" label="Electrify (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Warpath"></Skill>
854+
<Skill enabled="true" includeInFullDPS="false" index="16" label="Shock (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Warpath"></Skill>
855+
<Skill enabled="true" includeInFullDPS="false" index="17" label="Axe Throw (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Warpath"></Skill>
856+
<Skill enabled="true" includeInFullDPS="false" index="18" label="Shred Armor (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Javelin"></Skill>
857+
<Skill enabled="true" includeInFullDPS="false" index="19" label="Bleed (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Javelin"></Skill>
858+
<Skill enabled="true" includeInFullDPS="false" index="20" label="Blind (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Javelin"></Skill>
859+
<Skill enabled="true" includeInFullDPS="false" index="21" label="Electrify (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Javelin"></Skill>
860+
<Skill enabled="true" includeInFullDPS="false" index="22" label="Frailty (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:Javelin"></Skill>
861+
<Skill enabled="true" includeInFullDPS="false" index="23" label="Ignite (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Javelin"></Skill>
862+
<Skill enabled="true" includeInFullDPS="false" index="24" label="Shock (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Javelin"></Skill>
863+
<Skill enabled="true" includeInFullDPS="false" index="25" label="Slow (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:Javelin"></Skill>
864+
<Skill enabled="true" includeInFullDPS="false" index="26" label="Axe Throw (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Javelin"></Skill>
865+
<Skill enabled="true" includeInFullDPS="true" index="27" label="Shred Armor (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:AxeThrow"></Skill>
866+
<Skill enabled="true" includeInFullDPS="true" index="28" label="Blind (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:AxeThrow"></Skill>
867+
<Skill enabled="true" includeInFullDPS="true" index="29" label="Electrify (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:AxeThrow"></Skill>
868+
<Skill enabled="true" includeInFullDPS="true" index="30" label="Ignite (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:AxeThrow"></Skill>
869+
<Skill enabled="true" includeInFullDPS="true" index="31" label="Shock (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:AxeThrow"></Skill>
870+
<Skill enabled="true" includeInFullDPS="true" index="32" label="Axe Throw (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:AxeThrow"></Skill>
871+
<Skill enabled="true" includeInFullDPS="true" index="34" label="Bleed (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:AxeThrow"></Skill>
872+
<Skill enabled="true" includeInFullDPS="true" index="43" label="Frailty (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:AxeThrow"></Skill>
873+
<Skill enabled="true" includeInFullDPS="true" index="46" label="Slow (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:AxeThrow"></Skill>
858874
</SkillSet>
859875
</Skills>
860876
<Tree activeSpec="1">

0 commit comments

Comments
 (0)