Fix musl 64bit time_t on 32bit arm #1026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some architectures (like armv7) it will output invalid data if the size of the format and size of variable are different (after normal integer promotion). The calling convention on x86 doesn't have this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl warns if you include <sys/poll.h> rather than <poll.h>. Man page says <poll.h> so prefer that. I don't know if any systems only have <sys/poll.h> so I left that there as a fallback.
On some architectures (like armv7) it will output invalid data if
the size of the format and size of variable are different (after normal
integer promotion). The calling convention on x86 doesn't have this issue.
Fixes: #1025