wip

Author: tadhgboyle

modules/Core/classes/Tasks/Upgrade.php

@@ -17,6 +17,8 @@ public function run(): string
             // Acquire lock to prevent concurrent upgrades
             $this->acquireLock();
 
+            Settings::set('maintenance', '1');
+
             $updateCheck = $this->validateUpdateAvailable();
 
             $upgradeZipPath = $this->downloadUpgradePackage($updateCheck);
@@ -27,15 +29,15 @@ public function run(): string
 
             Settings::set('nameless_version', $updateCheck->versionTag());
             Settings::set('version_update', null);
-
-            $this->deleteUpgradeZip($upgradeZipPath);
         } catch (Exception $e) {
             $this->setOutput(['error' => $e->getMessage()]);
 
             return Task::STATUS_FAILED;
         } finally {
             // Ensure the lock is released even if an error occurs
             $this->releaseLock();
+
+            Settings::set('maintenance', '0');
         }
 
         return Task::STATUS_COMPLETED;
@@ -114,6 +116,10 @@ public function extractUpgradePackage(string $upgradeZipPath): void
         }
 
         $zip->close();
+
+        // Remove the zip file after extraction
+        unlink($upgradeZipPath);
+
         $this->setOutput(['zip_extract' => 'Upgrade package extracted successfully']);
     }
 
@@ -167,15 +173,6 @@ private function executeMigrations(): void
         ]);
     }
 
-    private function deleteUpgradeZip(string $upgradeZipPath): void
-    {
-        if (file_exists($upgradeZipPath) && !unlink($upgradeZipPath)) {
-            $this->setOutput(['delete_upgrade_zip' => 'Could not delete upgrade zip file']);
-        } else {
-            $this->setOutput(['delete_upgrade_zip' => 'Upgrade zip file deleted successfully']);
-        }
-    }
-
     private function getTempDirectory(): string
     {
         $tmpDir = ini_get('upload_tmp_dir');