note

tadhgboyle · tadhgboyle · commit c263bbc0047a · 2025-06-14T10:13:55.000-07:00
diff --git a/modules/Core/classes/Tasks/Upgrade.php b/modules/Core/classes/Tasks/Upgrade.php
@@ -204,7 +204,7 @@ private function verifyChecksum(string $upgradeZipPath, UpdateCheck $updateCheck
     private function executeMigrations(): bool
     {
         $process = new Process([
-            (new PhpExecutableFinder())->find(),
+            (new PhpExecutableFinder())->find(), // returns '' locally, could be a laravel valet quirk? works if i hardcode full homebrew path
             'vendor/bin/phinx',
             'migrate',
             '-c',

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ private function verifyChecksum(string $upgradeZipPath, UpdateCheck $updateCheck`
`204`	`204`	`private function executeMigrations(): bool`
`205`	`205`	`{`
`206`	`206`	`$process = new Process([`
`207`		`- (new PhpExecutableFinder())->find(),`
	`207`	`+ (new PhpExecutableFinder())->find(), // returns '' locally, could be a laravel valet quirk? works if i hardcode full homebrew path`
`208`	`208`	`'vendor/bin/phinx',`
`209`	`209`	`'migrate',`
`210`	`210`	`'-c',`