Merge pull request #8 from NimbleBrainInc/bug/valueFrom

Fix: Add valueFrom support to extraEnv

Author: mgoldsborough

.github/workflows/ci.yml

@@ -15,6 +15,7 @@ jobs:
       mcp-operator: ${{ steps.changes.outputs.mcp-operator }}
       universal_adapter: ${{ steps.changes.outputs.universal_adapter }}
       rbac-controller: ${{ steps.changes.outputs.rbac-controller }}
+      chart: ${{ steps.changes.outputs.chart }}
     steps:
       - uses: actions/checkout@v5
       - uses: dorny/paths-filter@v3
@@ -29,6 +30,9 @@ jobs:
               - 'universal-adapter/**'
             rbac-controller:
               - 'rbac-controller/**'
+            chart:
+              - 'chart/**'
+              - 'scripts/test-chart.sh'
 
   # Control Plane CI
   control-plane:
@@ -154,6 +158,35 @@ jobs:
           name: rbac-controller-coverage
           fail_ci_if_error: false
 
+  # Helm Chart CI
+  helm-chart:
+    runs-on: ubuntu-latest
+    needs: changes
+    if: needs.changes.outputs.chart == 'true'
+
+    steps:
+      - uses: actions/checkout@v5
+
+      - name: Install Helm
+        uses: azure/setup-helm@v4
+        with:
+          version: '3.13.0'
+
+      - name: Install helm-unittest plugin
+        run: helm plugin install https://github.com/helm-unittest/helm-unittest
+
+      - name: Build chart dependencies
+        run: helm dependency build chart/
+
+      - name: Run helm lint
+        run: helm lint chart/
+
+      - name: Run helm unit tests
+        run: helm unittest chart/
+
+      - name: Validate template rendering
+        run: helm template test-release chart/ > /dev/null
+
   # Docker builds
   docker-control-plane:
     runs-on: ubuntu-latest
@@ -221,6 +254,7 @@ jobs:
         mcp-operator,
         universal-adapter,
         rbac-controller,
+        helm-chart,
         docker-control-plane,
         docker-mcp-operator,
       ]
@@ -270,4 +304,12 @@ jobs:
             fi
           fi
 
+          # Helm chart checks
+          if [[ "${{ needs.changes.outputs.chart }}" == "true" ]]; then
+            if [[ "${{ needs.helm-chart.result }}" != "success" ]]; then
+              echo "Helm chart CI failed"
+              exit 1
+            fi
+          fi
+
           echo "All applicable CI checks passed!"

CHANGELOG.md

@@ -5,6 +5,28 @@ All notable changes to NimbleTools Core will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.2] - 2025-10-12
+
+### Fixed
+- Helm chart `extraEnv` now supports `valueFrom` for referencing Kubernetes secrets, ConfigMaps, and pod metadata
+- All three components (control-plane, operator, rbac-controller) now support standard Kubernetes secret management patterns
+- Chart.yaml now properly declares nginx-ingress as a dependency to fix helm lint warnings
+
+### Added
+- Comprehensive Helm chart testing infrastructure using helm-unittest plugin
+- 18 automated tests covering extraEnv functionality across all components
+- `docs/HELM_CONFIGURATION.md` - Complete guide for Helm chart configuration with extraEnv examples
+- `docs/TESTING_HELM_CHARTS.md` - Guide for testing Helm charts using TDD principles
+- `scripts/test-chart.sh` - Automated test runner for chart validation
+- Makefile targets: `make test-chart`, `make verify-chart` for chart testing
+- Integration of chart tests into main `make verify` workflow
+- Chart.lock file to lock dependency versions
+
+### Changed
+- Helm chart templates now conditionally render `value` or `valueFrom` based on configuration
+- Chart testing now runs as part of CI/CD verification process
+- CI now runs `helm dependency build` before linting to validate subcharts
+
 ## [0.2.1] - 2025-10-08
 
 ### Fixed

Makefile

@@ -2,7 +2,7 @@
 .PHONY: help install verify check clean docker-build update-version
 
 # Version from VERSION file
-VERSION ?= 0.2.1
+VERSION ?= 0.2.2
 
 # Default target
 help: ## Show this help message
@@ -31,18 +31,35 @@ install-rbac-controller: ## Install rbac controller dependencies
 	@cd rbac-controller && uv sync --dev
 
 # Verification - single command for all quality checks
-verify: ## Run all verification steps (format, lint, type-check, test) in all modules
+verify: verify-code verify-chart ## Run all verification steps (code + chart tests)
+	@echo ""
+	@echo "✅ All modules verified successfully!"
+
+verify-code: ## Run verification for all Python modules
 	@echo "🔍 Running full verification suite for all modules..."
 	@echo "================================================"
 	@cd control-plane && $(MAKE) verify
 	@cd mcp-operator && $(MAKE) verify
 	@cd universal-adapter && $(MAKE) verify
 	@cd rbac-controller && $(MAKE) verify
-	@echo ""
-	@echo "✅ All modules verified successfully!"
 
 
 
+# Helm Chart Testing
+verify-chart: ## Run Helm chart unit tests
+	@echo "🧪 Running Helm chart tests..."
+	@./scripts/test-chart.sh
+
+test-chart: verify-chart ## Alias for verify-chart
+
+test-chart-verbose: ## Run Helm chart tests with verbose output
+	@echo "🧪 Running Helm chart tests (verbose)..."
+	@./scripts/test-chart.sh -v
+
+lint-chart: ## Lint Helm chart
+	@echo "🔍 Linting Helm chart..."
+	@helm lint chart/
+
 # Backwards compatibility alias
 check: verify ## Alias for verify (backwards compatibility)
 

VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

chart/Chart.lock

@@ -0,0 +1,6 @@
+dependencies:
+- name: nginx-ingress
+  repository: ""
+  version: 0.1.0
+digest: sha256:198e7cd76693dd1510ea3db16346cbcf09b4d3f128da68272bb0b83905d345a5
+generated: "2025-10-13T20:06:34.187856-10:00"

chart/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v2
 name: nimbletools-core
 description: Open-source MCP service runtime for Kubernetes
-version: 0.2.1
-appVersion: "0.2.1"
+version: 0.2.2
+appVersion: "0.2.2"
 home: https://www.nimbletools.ai
 sources:
   - https://github.com/nimblebrain/nimbletools-core
@@ -16,3 +16,7 @@ keywords:
   - kubernetes
   - serverless
 type: application
+dependencies:
+  - name: nginx-ingress
+    version: 0.1.0
+    condition: nginx-ingress.enabled

chart/templates/control_plane.yaml

@@ -38,7 +38,12 @@ spec:
           value: {{ .Values.global.domain }}
         {{- range .Values.extraEnv }}
         - name: {{ .name }}
+          {{- if .value }}
           value: {{ .value | quote }}
+          {{- else if .valueFrom }}
+          valueFrom:
+            {{- toYaml .valueFrom | nindent 12 }}
+          {{- end }}
         {{- end }}
         ports:
         - name: http

chart/templates/operator.yaml

@@ -42,7 +42,12 @@ spec:
           value: "false"
         {{- range .Values.extraEnv }}
         - name: {{ .name }}
+          {{- if .value }}
           value: {{ .value | quote }}
+          {{- else if .valueFrom }}
+          valueFrom:
+            {{- toYaml .valueFrom | nindent 12 }}
+          {{- end }}
         {{- end }}
         ports:
         - name: metrics

chart/templates/rbac-controller.yaml

@@ -100,7 +100,12 @@ spec:
               fieldPath: metadata.namespace
         {{- range .Values.extraEnv }}
         - name: {{ .name }}
+          {{- if .value }}
           value: {{ .value | quote }}
+          {{- else if .valueFrom }}
+          valueFrom:
+            {{- toYaml .valueFrom | nindent 12 }}
+          {{- end }}
         {{- end }}
         resources:
           {{- toYaml .Values.rbacController.resources | nindent 10 }}