Skip to content

Commit f59d1cf

Browse files
refactor: remove BrowserRouter from App component and wrap it in main.tsx for better routing structure
1 parent 0e7ef8c commit f59d1cf

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

spring-scribe-shine-main/src/App.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Toaster } from "@/components/ui/toaster";
22
import { Toaster as Sonner } from "@/components/ui/sonner";
33
import { TooltipProvider } from "@/components/ui/tooltip";
44
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
5-
import { BrowserRouter, Routes, Route } from "react-router-dom";
5+
import { Routes, Route } from "react-router-dom";
66
import Index from "./pages/Index";
77
import NotFound from "./pages/NotFound";
88

@@ -13,13 +13,11 @@ const App = () => (
1313
<TooltipProvider>
1414
<Toaster />
1515
<Sonner />
16-
<BrowserRouter>
17-
<Routes>
18-
<Route path="/" element={<Index />} />
19-
{/* ADD ALL CUSTOM ROUTES ABOVE THE CATCH-ALL "*" ROUTE */}
20-
<Route path="*" element={<NotFound />} />
21-
</Routes>
22-
</BrowserRouter>
16+
<Routes>
17+
<Route path="/" element={<Index />} />
18+
{/* ADD ALL CUSTOM ROUTES ABOVE THE CATCH-ALL "*" ROUTE */}
19+
<Route path="*" element={<NotFound />} />
20+
</Routes>
2321
</TooltipProvider>
2422
</QueryClientProvider>
2523
);
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
import { createRoot } from 'react-dom/client'
22
import App from './App.tsx'
33
import './index.css'
4+
import { BrowserRouter } from 'react-router-dom'
45

5-
createRoot(document.getElementById("root")!).render(<App />);
6+
createRoot(document.getElementById("root")!).render(
7+
<BrowserRouter basename="/java-fundamentals-for-spring">
8+
<App />
9+
</BrowserRouter>
10+
);

0 commit comments

Comments
 (0)