Skip to content

Commit 9ddcda8

Browse files
committed
Modified CPHeader.jsx, BellNotification.js, Header.jsx, Member.jsx, Timelog.jsx, SlideToggle.jsx
1 parent b982ce0 commit 9ddcda8

File tree

6 files changed

+12
-19
lines changed

6 files changed

+12
-19
lines changed

src/components/CommunityPortal/CPHeader/CPHeader.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@ export function Header(props) {
338338
{UPDATE_PASSWORD}
339339
</DropdownItem>
340340
)}
341-
<DropdownItem className={darkMode ? 'text-light' : ''}>
341+
<div style={{ padding: '0 1rem' }}>
342342
<DarkModeButton />
343-
</DropdownItem>
343+
</div>
344344
<DropdownItem divider />
345345
<DropdownItem onClick={openModal} className={darkMode ? 'text-light' : ''}>
346346
{LOGOUT}

src/components/Header/BellNotification.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export default function BellNotification({ userId }) {
101101
};
102102

103103
useEffect(() => {
104+
if (!userId) return;
104105
const fetchDbNotifications = async () => {
105106
try {
106107
const { data } = await axios.get(`${ENDPOINTS.NOTIFICATIONS}/unread/user/${userId}`);

src/components/Header/Header.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,10 @@ export function Header(props) {
201201
props.getAllRoles();
202202
}
203203
// Fetch unread notification
204-
if (isAuthenticated && userId) {
205-
dispatch(getUnreadUserNotifications(userId));
204+
if (isAuthenticated && displayUserId) {
205+
dispatch(getUnreadUserNotifications(displayUserId));
206206
}
207-
}, []);
207+
}, [isAuthenticated, displayUserId, roles.length]);
208208

209209
useEffect(() => {
210210
if (props.notification?.error) {

src/components/Projects/Members/Member/Member.jsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { boxStyle } from '~/styles';
1111
import PropTypes from 'prop-types';
1212

1313

14-
const Member = props => {
14+
const Member = ({ index = 0, ...props }) => {
1515
const { darkMode } = props;
1616
const canGetProjectMembers = hasPermission('getProjectMembers');
1717
const canUnassignUserInProject = hasPermission('unassignUserInProject');
@@ -21,7 +21,7 @@ const Member = props => {
2121
<React.Fragment>
2222
<tr className={`members__tr ${darkMode ? 'bg-space-cadet' : ''}`}>
2323
<th scope="row">
24-
<div>{typeof props.index === 'number' ? props.index + 1 : null}</div>
24+
<div>{typeof index === 'number' ? index + 1 : null}</div>
2525
</th>
2626
<td className="members__name">
2727
{canGetProjectMembers ? (
@@ -53,10 +53,7 @@ const Member = props => {
5353
);
5454
};
5555

56-
// Define default props
57-
Member.defaultProps = {
58-
index: 0
59-
};
56+
// ...existing code...
6057

6158
// Define prop types
6259
Member.propTypes = {

src/components/Timelog/Timelog.jsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,9 +1208,7 @@ Timelog.prototype = {
12081208
userId: PropTypes.string,
12091209
};
12101210

1211-
Timelog.defaultProps = {
1212-
userId: null,
1213-
};
1211+
// ...existing code...
12141212

12151213
const mapStateToProps = state => ({
12161214
authUser: state.auth.user,

src/components/WeeklySummariesReport/components/SlideToggle.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import cn from 'classnames';
55
import styles from './SlideToggle.module.scss';
66

77
// eslint-disable-next-line react/function-component-definition
8-
const SlideToggle = ({ color = 'default', onChange, className }) => {
8+
const SlideToggle = ({ color = 'default', className = '', onChange }) => {
99
const [checked, setChecked] = useState(false);
1010

1111
return (
@@ -24,10 +24,7 @@ const SlideToggle = ({ color = 'default', onChange, className }) => {
2424
);
2525
};
2626

27-
SlideToggle.defaultProps = {
28-
color: 'default',
29-
className: '',
30-
};
27+
// ...existing code...
3128

3229
SlideToggle.propTypes = {
3330
color: PropTypes.oneOf(['default', 'purple', 'green', 'navy']),

0 commit comments

Comments
 (0)