Review feedback

Author: cdmayer

README.md

@@ -74,7 +74,9 @@ can begin making calls using the SDK.
 
 To interact with the OneDrive API, your app must authenticate for a specific resource. Your
 app must first use the Resource Discovery helper to find out which service you can access.
-Then, you can build a client to access those resources.
+Then, you can build a client to access those resources. This uses a slightly different
+auth flow than the standard code flow - note the use of `redeem_refresh_token` with
+the `service_resource_id` of the service you want to access.
 
 ```python
 import onedrivesdk

src/onedrivesdk/auth_provider.py

@@ -111,7 +111,7 @@ def scopes(self, value):
     @property
     def access_token(self):
         """Gets and sets the access_token for the
-        AuthProvider
+            :class:`AuthProvider`
 
         Returns:
             str: The access token. Looks at the session to figure out what the access token is, since this
@@ -124,7 +124,7 @@ class does not directly store the access token.
     @property
     def auth_server_url(self):
         """Gets and sets the authorization server url for the
-        AuthProvider
+            :class:`AuthProvider`
 
         Returns:
             str: Auth server url

src/onedrivesdk/extensions/onedrivesdk_helper.py

@@ -50,7 +50,7 @@ def get_business_client(client_id, scopes, base_url):
         scopes (list of str): The scopes required for your
             application
         base_url (str): Base URL of OneDrive for Business tenant.
-        For example, "https://my-sharepoint.contoso.com/v1.0/"
+            For example, "https://my-sharepoint.contoso.com/v1.0/"
 
     Returns:
         :class:`OneDriveClient<onedrivesdk.requests.one_drive_client.OneDriveClient>`:

src/onedrivesdk/helpers/get_access_token_server.py

@@ -75,7 +75,7 @@ def get_auth_token(auth_url, redirect_uri):
 class GetAccessTokenServer(HTTPServer, object):
 
     def __init__(self, server_address, stop_event, RequestHandlerClass):
-        HTTPServer.__init__(self, server_address, RequestHandlerClass)
+        super(HTTPServer, self).init(server_address, RequestHandlerClass)
         self._stop_event = stop_event
         self._access_token = None
         self._authentication_token = None

src/onedrivesdk/helpers/resource_discovery.py

@@ -30,6 +30,11 @@ def get_service_info(self, access_token):
 
 
 class ServiceInfo(object):
+    """
+    Objects representing ServiceInfo returned by the Discovery Service.
+        More info can be found here:
+        https://msdn.microsoft.com/en-us/office/office365/api/discovery-service-rest-operations
+    """
     def __init__(self, prop_dict={}):
         self._prop_dict = prop_dict
 
@@ -48,6 +53,12 @@ def _prop_dict_set(self, prop, val):
 
     @property
     def capability(self):
+        """
+
+        Returns:
+            str: The Capability of the service
+
+        """
         return self._prop_dict_get('capability')
 
     @capability.setter
@@ -56,6 +67,12 @@ def capability(self, value):
 
     @property
     def service_id(self):
+        """
+
+        Returns:
+            str: The ServiceId
+
+        """
         return self._prop_dict_get('serviceId')
 
     @service_id.setter
@@ -64,6 +81,12 @@ def service_id(self, value):
 
     @property
     def service_name(self):
+        """
+
+        Returns:
+            str: The name of the service
+
+        """
         return self._prop_dict_get('serviceName')
 
     @service_name.setter
@@ -72,6 +95,13 @@ def service_name(self, value):
 
     @property
     def service_endpoint_uri(self):
+        """
+
+        Returns:
+            str: The serviceEndpointUri
+                Ex: https://contoso-my.sharepoint.com/personal/alexd_contoso_com
+
+        """
         return self._prop_dict_get('serviceEndpointUri')
 
     @service_endpoint_uri.setter
@@ -80,6 +110,13 @@ def service_endpoint_uri(self, value):
 
     @property
     def service_resource_id(self):
+        """
+
+        Returns:
+            str: the serviceResourceId
+                Ex: https://contoso-my.sharepoint.com/
+
+        """
         return self._prop_dict_get('serviceResourceId')
 
     @service_resource_id.setter
@@ -88,6 +125,12 @@ def service_resource_id(self, value):
 
     @property
     def service_api_version(self):
+        """
+
+        Returns:
+            str: the serviceApiVersion
+
+        """
         return self._prop_dict_get('serviceApiVersion')
 
     @service_api_version.setter