Skip to content

Commit 87231c3

Browse files
authored
[php][php-nextgen] add new github workflow to perform syntax check on php files (#21678)
* update php laravel samples * add php-nextgen to the github workflow * trigger build failure * add syntax checker workflow * Revert "trigger build failure" This reverts commit 5be28f2.
1 parent f846f30 commit 87231c3

File tree

10 files changed

+132
-329
lines changed

10 files changed

+132
-329
lines changed
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: Samples PHP Syntax Checker
2+
3+
on:
4+
push:
5+
paths:
6+
- samples/client/petstore/php/OpenAPIClient-php/**
7+
- samples/client/petstore/php-nextgen/OpenAPIClient-php/**
8+
pull_request:
9+
paths:
10+
- samples/client/petstore/php/OpenAPIClient-php/**
11+
- samples/client/petstore/php-nextgen/OpenAPIClient-php/**
12+
jobs:
13+
build:
14+
name: Build PHP projects
15+
runs-on: ubuntu-latest
16+
strategy:
17+
fail-fast: false
18+
matrix:
19+
php:
20+
- "8.1"
21+
- "8.2"
22+
- "8.3"
23+
- "8.4"
24+
sample:
25+
# clients
26+
- samples/client/petstore/php/OpenAPIClient-php/
27+
- samples/client/petstore/php-nextgen/OpenAPIClient-php/
28+
steps:
29+
- uses: actions/checkout@v4
30+
- name: Setup PHP with tools
31+
uses: shivammathur/setup-php@v2
32+
with:
33+
php-version: "${{ matrix.php }}"
34+
- name: php -l
35+
working-directory: ${{ matrix.sample }}
36+
run: find . -name "*.php" -exec php -l {} +

samples/client/petstore/php-nextgen/OpenAPIClient-php/.openapi-generator-ignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,5 @@
2121
#docs/*.md
2222
# Then explicitly reverse the ignore rule for a single file:
2323
#!docs/README.md
24+
#
25+
#

samples/server/petstore/php-laravel-issue-21334/Http/Controllers/DefaultController.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,8 @@ public function getDummy(Request $request): JsonResponse
7979

8080
$param_withRandomCase = $request->string('param_withRandomCase')->value();
8181

82-
try {
83-
$apiResult = $this->api->getDummy($paramCamelCase, $ParamPascalCase, $param_withRandomCase);
84-
} catch (\Exception $exception) {
85-
// This shouldn't happen
86-
report($exception);
87-
return response()->json(['error' => $exception->getMessage()], 500);
88-
}
82+
83+
$apiResult = $this->api->getDummy($paramCamelCase, $ParamPascalCase, $param_withRandomCase);
8984

9085
if ($apiResult instanceof \OpenAPI\Server\Model\NoContent200) {
9186
return response()->json($this->serde->serialize($apiResult, format: 'array'), 200);

samples/server/petstore/php-laravel/Http/Controllers/AnotherFakeController.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,8 @@ public function call123TestSpecialTags(Request $request): JsonResponse
6666

6767
$client = $this->serde->deserialize($request->getContent(), from: 'json', to: \OpenAPI\Server\Model\Client::class);
6868

69-
try {
70-
$apiResult = $this->api->call123TestSpecialTags($client);
71-
} catch (\Exception $exception) {
72-
// This shouldn't happen
73-
report($exception);
74-
return response()->json(['error' => $exception->getMessage()], 500);
75-
}
69+
70+
$apiResult = $this->api->call123TestSpecialTags($client);
7671

7772
if ($apiResult instanceof \OpenAPI\Server\Model\Client) {
7873
return response()->json($this->serde->serialize($apiResult, format: 'array'), 200);

samples/server/petstore/php-laravel/Http/Controllers/DefaultController.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,8 @@ public function fooGet(Request $request): JsonResponse
6464
return response()->json(['error' => 'Invalid input'], 400);
6565
}
6666

67-
try {
68-
$apiResult = $this->api->fooGet();
69-
} catch (\Exception $exception) {
70-
// This shouldn't happen
71-
report($exception);
72-
return response()->json(['error' => $exception->getMessage()], 500);
73-
}
67+
68+
$apiResult = $this->api->fooGet();
7469

7570
if ($apiResult instanceof \OpenAPI\Server\Model\FooGetDefaultResponse) {
7671
return response()->json($this->serde->serialize($apiResult, format: 'array'), 0);

samples/server/petstore/php-laravel/Http/Controllers/FakeClassnameTags123Controller.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,8 @@ public function testClassname(Request $request): JsonResponse
6666

6767
$client = $this->serde->deserialize($request->getContent(), from: 'json', to: \OpenAPI\Server\Model\Client::class);
6868

69-
try {
70-
$apiResult = $this->api->testClassname($client);
71-
} catch (\Exception $exception) {
72-
// This shouldn't happen
73-
report($exception);
74-
return response()->json(['error' => $exception->getMessage()], 500);
75-
}
69+
70+
$apiResult = $this->api->testClassname($client);
7671

7772
if ($apiResult instanceof \OpenAPI\Server\Model\Client) {
7873
return response()->json($this->serde->serialize($apiResult, format: 'array'), 200);

0 commit comments

Comments
 (0)