[BUG][typescript-fetch] OneOf models missing closing parentheses in ToJSONTyped method in some cases

[btpnlsl]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

PR #21464 provided some changes to add serialization & deserialization logic for primitive and enum types used by the ToJSONTypes & FromJSONTyped methods of 'oneOf' models.

There are a couple of cases where the if-statements used in the ToJSONTyped methods generated by the template are missing closing parentheses, such as when serializing an Array<number>, Array<string>.

This can be seen in the example provided with the PR:

    if (Array.isArray(value)) {
        // the following line is missing a closing parenthesis
        if (value.every(item => typeof item === 'number') {
            return value;
        }
    }

    if (Array.isArray(value)) {
        // the following line is missing a closing parenthesis
        if (value.every(item => typeof item === 'string') {
            return value;
        }
    }

openapi-generator version

current version of master branch (as of commit ef22749)

OpenAPI declaration file content or url

issue_21259.yaml

Generation Details

Generate code using the unit test in TypeScriptFetchClientCodegenTest.givenSchemaIsOneOfAndComposedSchemasArePrimitiveThenReturnStatementsAreCorrect

Steps to reproduce

See above

Related issues/PRs

#21259 - @DavidGrath

Suggest a fix

modelOneOf.mustache in the typescript generator needs to be fixed to add closing parenthesis for these cases.
The unit test needs to be modified to check for the correct number of close parenthesis or an integration test needs to be created that exercises the code.

[DavidGrath]

@btpnlsl , thank you for spotting that, I don't know how I missed it. I see you've already created a related PR (#21638). Do you want to modify the mustache file on that branch or do you want to leave me to fix it? Also, please can you confirm if the issue exists on the first line? It seems okay to me

[btpnlsl]

@DavidGrath I have a PR ready to go with that fix and another with the fix for #21587. I was going to bring it in separately since the change I have out already was scoped to just improving the unit tests.

You are correct, the issue doesn't exist for the first line in the sample. I will edit my comment to remove the line.

I was also thinking that it might be nice to have a build process that can run some sort of linting or checking on the results of the typescript samples to catch these types of mistakes a bit easier. It's really easy to lose track of how many parenthesis or braces you've closed when your editing a mustache template with a bunch of logic.