Merge pull request 'chore: gpt-5 not support topP' (#460) from spec_config into development

Reviewed-on: https://git.biggo.com/Funmula/dive-mcp-host/pulls/460

Author: LouisFunmula

dive_mcp_host/host/conf/llm.py

@@ -161,15 +161,19 @@ def temperature_top_p(self) -> Self:
         ):
             self.configuration.top_p = None
 
-        if (
-            "gpt-5" in self.model
-            and self.configuration
-            and (temperature := self.configuration.temperature)
-        ):
-            if temperature > 0:
+        if "gpt-5" in self.model and self.configuration:
+            temperature = self.configuration.temperature
+            top_p = self.configuration.top_p
+
+            if temperature and temperature > 0:
                 self.configuration.temperature = 1
-            else:
+            elif temperature == 0:
                 self.configuration.temperature = None
+
+            # gpt 5 is not supported for top_p
+            if top_p is not None:
+                self.configuration.top_p = None
+
         return self
 
 

tests/test_models.py

@@ -304,11 +304,12 @@ def test_gpt_5_temperature() -> None:
     assert "temperature" not in kwargs
 
     simple_2 = raw_config.copy()
-    simple_2["configuration"] = {"temperature": 0.5}
+    simple_2["configuration"] = {"temperature": 0.5, "top_p": 0.5}
     llm_config = LLMConfig.model_validate(simple_2)
     kwargs = llm_config.to_load_model_kwargs()
     assert "temperature" in kwargs
     assert kwargs["temperature"] == 1
+    assert "top_p" not in kwargs
 
     simple_3 = raw_config.copy()
     simple_3["configuration"] = {"temperature": 0}
@@ -323,6 +324,7 @@ def test_gpt_5_temperature() -> None:
     kwargs = llm_config.to_load_model_kwargs()
     assert "temperature" in kwargs
     assert kwargs["temperature"] == 1
+    assert "top_p" not in kwargs
 
     # test general llm config
     simple_5 = simple_2.copy()
@@ -331,3 +333,5 @@ def test_gpt_5_temperature() -> None:
     kwargs = llm_config.to_load_model_kwargs()
     assert "temperature" in kwargs
     assert kwargs["temperature"] == 0.5
+    assert "top_p" in kwargs
+    assert kwargs["top_p"] == 0.5