feature/Cannot create consent for max amount - 180 Days

Author: constantine2nd

obp-api/src/main/scala/code/api/berlin/group/v1_3/BgSpecValidation.scala

@@ -36,10 +36,10 @@ object BgSpecValidation {
 
       if (date.isBefore(today)) {
         Left(s"$InvalidDateFormat The `validUntil` date ($dateStr) cannot be in the past!")
-      } else if (date.isEqual(MaxValidDays) || date.isAfter(MaxValidDays)) {
+      } else if (date.isAfter(MaxValidDays)) {
         Left(s"$InvalidDateFormat The `validUntil` date ($dateStr) exceeds the maximum allowed period of 180 days (until $MaxValidDays).")
       } else {
-        Right(date) // Valid date
+        Right(date) // Valid date (inclusive of 180 days)
       }
     } catch {
       case _: DateTimeParseException =>
@@ -55,23 +55,4 @@ object BgSpecValidation {
     }
   }
 
-  // Example usage
-  def main(args: Array[String]): Unit = {
-    val testDates = Seq(
-      "2025-05-10",  // More than 180 days ahead
-      "9999-12-31",  // Exceeds max allowed
-      "2015-01-01",  // In the past
-      "invalid-date", // Invalid format
-      LocalDate.now().plusDays(90).toString,  // Valid (within 180 days)
-      LocalDate.now().plusDays(180).toString, // Valid (exactly 180 days)
-      LocalDate.now().plusDays(181).toString  // More than 180 days
-    )
-
-    testDates.foreach { date =>
-      validateValidUntil(date) match {
-        case Right(validDate) => println(s"Valid date: $validDate")
-        case Left(error)      => println(s"Error: $error")
-      }
-    }
-  }
 }

obp-api/src/test/scala/code/api/berlin/group/v1_3/BgSpecValidationTest.scala

@@ -0,0 +1,106 @@
+package code.api.berlin.group.v1_3
+
+import code.api.berlin.group.v1_3.BgSpecValidation._
+import code.api.v4_0_0.V400ServerSetup
+import org.scalatest.Tag
+
+import java.time.LocalDate
+import java.util.Date
+
+class BgSpecValidationTest extends V400ServerSetup {
+
+  // Test tags
+  object File extends Tag("BgSpecValidation.scala")
+  object Function1 extends Tag("validateValidUntil")
+  object Function2 extends Tag("getErrorMessage")
+  object Function3 extends Tag("getDate")
+  object Function4 extends Tag("formatToISODate")
+
+  feature(s"Test function: $Function1 at file $File") {
+
+    scenario("Reject past date", Function1) {
+      When("The client provides a date in the past")
+      val yesterday = LocalDate.now().minusDays(1).toString
+
+      Then("It should be rejected")
+      val error = getErrorMessage(yesterday)
+      error should include("cannot be in the past")
+    }
+
+    scenario("Accept today's date", Function1) {
+      When("The client provides today's date")
+      val today = LocalDate.now().toString
+
+      Then("It should be accepted")
+      val error = getErrorMessage(today)
+      error shouldBe ""
+    }
+
+    scenario("Accept exactly 180 days in the future", Function1) {
+      When("The client provides the maximum allowed date (180 days)")
+      val maxDay = MaxValidDays.toString
+
+      Then("It should be accepted")
+      val error = getErrorMessage(maxDay)
+      error shouldBe ""
+    }
+
+    scenario("Reject date beyond 180 days", Function1) {
+      When("The client provides a date 181 days in the future")
+      val tooFar = MaxValidDays.plusDays(1).toString
+
+      Then("It should be rejected")
+      val error = getErrorMessage(tooFar)
+      error should include("exceeds the maximum allowed period")
+    }
+
+    scenario("Reject invalid date format", Function1) {
+      When("The client provides a date in wrong format")
+      val invalid = "2025/12/31"
+
+      Then("It should be rejected")
+      val error = getErrorMessage(invalid)
+      error should include("invalid")
+    }
+  }
+
+  feature(s"Test function: $Function2 and $Function3 at file $File") {
+
+    scenario("getDate returns valid Date for correct input", Function3) {
+      When("We provide a valid ISO date")
+      val today = LocalDate.now().toString
+      val result = getDate(today)
+
+      Then("It should return a non-null Date")
+      result shouldBe a[Date]
+    }
+
+    scenario("getDate returns null for invalid input", Function3) {
+      When("We provide an invalid date format")
+      val result = getDate("2025/12/31")
+
+      Then("It should return null")
+      result shouldBe null
+    }
+  }
+
+  feature(s"Test function: $Function4 at file $File") {
+
+    scenario("formatToISODate formats a valid Date", Function4) {
+      When("We pass a valid Date object")
+      val today = new Date()
+      val formatted = formatToISODate(today)
+
+      Then("It should return an ISO date string")
+      formatted should fullyMatch regex """\d{4}-\d{2}-\d{2}"""
+    }
+
+    scenario("formatToISODate handles null gracefully", Function4) {
+      When("We pass null")
+      val formatted = formatToISODate(null)
+
+      Then("It should return empty string")
+      formatted shouldBe ""
+    }
+  }
+}