-
Notifications
You must be signed in to change notification settings - Fork 19
Add Missing Tests for delete Account Functionality #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Agaba-derrick
wants to merge
7
commits into
OpenElements:main
Choose a base branch
from
Agaba-derrick:Add-delete-Account-Tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Missing Tests for delete Account Functionality #179
Agaba-derrick
wants to merge
7
commits into
OpenElements:main
from
Agaba-derrick:Add-delete-Account-Tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Ndacyayisenga-droid @Jexsie please kindly review ! |
84081d2
to
d1bc5d8
Compare
Hey @Agaba-derrick. Thanks for the contribution! Could you sign the DCO https://github.com/OpenElements/hiero-enterprise-java/pull/179/checks?check_run_id=42593910068 |
hiero-enterprise-base/src/test/java/com/openelements/hiero/base/test/AccountClientImplTest.java
Outdated
Show resolved
Hide resolved
87a4a97
to
0396fda
Compare
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
87a4a97
to
a4e308c
Compare
hendrikebbers
requested changes
May 30, 2025
hiero-enterprise-base/src/test/java/com/openelements/hiero/base/test/AccountClientImplTest.java
Outdated
Show resolved
Hide resolved
hiero-enterprise-base/src/test/java/com/openelements/hiero/base/test/AccountClientImplTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountClientImpl Delete Methods - Unit Tests
Overview
This set of unit tests targets the
deleteAccount
methods of theAccountClientImpl
class, ensuring robust behavior around account deletion operations.Key Features Tested
Successful Account Deletion
Validates that the
ProtocolLayerClient.executeAccountDeleteTransaction
method is invoked once when deleting an account.Account Deletion with Fund Transfer
Tests the overloaded
deleteAccount
method which deletes an account and transfers remaining funds to another account, confirming correct client method invocation.Exception Handling
Checks that the methods throw or propagate expected exceptions (e.g.,
HieroException
) when invalid parameters are passed or underlying client errors occur.Mocking Approach
ProtocolLayerClient
dependency.doNothing()
for stubbing void methods properly.assertThrows
for verifying exception scenarios.Issue
Closes #108