Merge pull request #87 from Ally-Guide/lint

Lint all the things

Author: JamesMGreene

.eslintrc.json

@@ -5,10 +5,9 @@
         "node": true,
         "jest": true
     },
-    "extends": "eslint:recommended",
+    "extends": ["eslint:recommended"],
     "parserOptions": {
         "ecmaVersion": 12
     },
-    "rules": {
-    }
+    "rules": {}
 }

.github/workflows/lint.yml

@@ -0,0 +1,31 @@
+name: Lint
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+  pull_request:
+
+env:
+  CI: true
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - name: Check out repo
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
+
+      - name: Setup node
+        uses: actions/setup-node@38d90ce44d5275ad62cc48384b3d8a58c500bb5f
+        with:
+          node-version: 16.x
+          cache: npm
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run linter
+        run: npm run lint-check

package.json

@@ -7,7 +7,8 @@
   "scripts": {
     "test": "jest --detectOpenHandles --forceExit",
     "format": "prettier --write 'server/**/*.js'",
-    "lint": "eslint 'server/**/*.js'",
+    "lint": "eslint --fix .",
+    "lint-check": "eslint .",
     "start": "node server/server.js",
     "dev": "nodemon server/server.js",
     "db:create": "npm run db:create:dev && npm run db:create:test",

script/create-db.js

@@ -64,6 +64,7 @@ async function migrateToLatestSchemas (config) {
   }
 }
 
+// eslint-disable-next-line no-unused-vars
 async function runDataSeeders (config) {
   const { database } = config.connection
   let db

server/db/_migration.stub.js

@@ -1,11 +1,9 @@
 module.exports = {
-
-  async up (knex) {
-    // await knex...
+  async up(knex) {
+    await knex.schema.doSomethingForReal()
   },
 
-  async down (knex) {
-    // await knex...
-  }
-
+  async down(knex) {
+    await knex.schema.doSomethingForReal()
+  },
 }

server/routes/api/campaigns.js

@@ -1,5 +1,4 @@
 const express = require('express')
-const axios = require('axios')
 const { createClient } = require('../../db')
 const router = express.Router()
 const db = createClient()

server/routes/api/letter_versions.js

@@ -1,5 +1,4 @@
 const express = require('express')
-const axios = require('axios')
 const { createClient } = require('../../db')
 const router = express.Router()
 const db = createClient()

server/routes/api/lob.js

@@ -1,10 +1,8 @@
 const express = require('express')
 const axios = require('axios')
-const { createClient } = require('../../db')
 const Lob = require('lob')
 
 const router = express.Router()
-const db = createClient()
 
 const ALLOWED_ADDRESS_FIELDS = ['line1', 'line2', 'city', 'state', 'zip']
 const VALID_US_ZIP_CODE_MATCH = /^(?:\d{1,4}|\d{5}(?:[+-]?\d{4})?)$/