Add integrity into st30 test cases

Author: andremiszcz

tests/validation/mtl_engine/integrity.py

@@ -76,61 +76,76 @@ def check_st30p_integrity(src_url: str, out_url: str, size: int):
     return True
 
 
-def calculate_st30p_framebuff_size(
-    format: str, ptime: str, sampling: str, channel: str
-):
+def get_sample_size(format: str) -> int:
     match format:
         case "PCM8":
-            sample_size = 1
+            return 1
         case "PCM16":
-            sample_size = 2
+            return 2
         case "PCM24":
-            sample_size = 3
+            return 3
+        case _:
+            log_fail(f"Unknown audio format: {format}")
+            return 0
+
 
+def get_sample_number(sampling: str, ptime: str) -> int:
     match sampling:
         case "48kHz":
             match ptime:
                 case "1":
-                    sample_num = 48
+                    return 48
                 case "0.12":
-                    sample_num = 6
+                    return 6
                 case "0.25":
-                    sample_num = 12
+                    return 12
                 case "0.33":
-                    sample_num = 16
+                    return 16
                 case "4":
-                    sample_num = 192
+                    return 192
         case "96kHz":
             match ptime:
                 case "1":
-                    sample_num = 96
+                    return 96
                 case "0.12":
-                    sample_num = 12
+                    return 12
                 case "0.25":
-                    sample_num = 24
+                    return 24
                 case "0.33":
-                    sample_num = 32
+                    return 32
                 case "4":
-                    sample_num = 384
+                    return 384
+    return 0
+
 
+def get_channel_number(channel: str) -> int:
     match channel:
         case "M":
-            channel_num = 1
+            return 1
         case "DM" | "ST" | "LtRt" | "AES3":
-            channel_num = 2
+            return 2
         case "51":
-            channel_num = 6
+            return 6
         case "71":
-            channel_num = 8
+            return 8
         case "222":
-            channel_num = 24
+            return 24
         case "SGRP":
-            channel_num = 4
+            return 4
         case _:
             match = re.match(r"^U(\d{2})$", channel)
 
             if match:
-                channel_num = int(match.group(1))
+                return int(match.group(1))
+    return 0
+
+
+def calculate_st30p_framebuff_size(
+    format: str, ptime: str, sampling: str, channel: str
+):
+    sample_size = get_sample_size(format)
+    sample_num = get_sample_number(sampling, ptime)
+    channel_num = get_channel_number(channel)
 
     packet_size = sample_size * sample_num * channel_num
 

tests/validation/mtl_engine/media_files.py

@@ -519,15 +519,15 @@
 
 audio_files = dict(
     PCM24={
-        "filename": "test.wav",
+        "filename": "voice_48k_24ch_1min_24pcm.raw",
         "format": "PCM24",
     },
     PCM16={
-        "filename": "test.wav",
+        "filename": "voice_48k_24ch_1min_24pcm.raw",
         "format": "PCM16",
     },
     PCM8={
-        "filename": "test.wav",
+        "filename": "voice_48k_24ch_1min_24pcm.raw",
         "format": "PCM8",
     },
 )

tests/validation/tests/single/rss_mode/audio/test_rss_mode_audio.py

@@ -6,6 +6,7 @@
 import pytest
 from common.integrity.integrity_runner import FileAudioIntegrityRunner
 from mtl_engine.execute import log_fail
+from mtl_engine.integrity import get_sample_size
 from mtl_engine.media_files import audio_files
 
 logger = logging.getLogger(__name__)
@@ -78,6 +79,7 @@ def test_rss_mode_audio(
             test_repo_path=build,
             src_url=media_file_path,
             out_name=out_file_url.name,
+            sample_size=get_sample_size(media_file_info["format"]),
             out_path=str(out_file_url.parent),
         )
         result = integrity.run()

tests/validation/tests/single/st30p/st30p_channel/test_st30p_channel.py

@@ -5,8 +5,8 @@
 import mtl_engine.RxTxApp as rxtxapp
 import pytest
 from common.integrity.integrity_runner import FileAudioIntegrityRunner
-from future.backports.test.pystone import TRUE
 from mtl_engine.execute import log_fail
+from mtl_engine.integrity import get_channel_number, get_sample_size
 from mtl_engine.media_files import audio_files
 from tests.xfail import SDBQ1001_audio_channel_check
 
@@ -56,7 +56,7 @@ def test_st30p_channel(
         f"test_st30p_channel_{media_file_info['format']}_{audio_channel}"  # e.g., test_st30p_channel_PCM8_M
     )
 
-    out_file_url = host.connection.path(media_file_path).parent / "out.wav"
+    out_file_url = host.connection.path(media_file_path).parent / "out.pcm"
 
     config = rxtxapp.create_empty_config()
     config = rxtxapp.add_st30p_sessions(
@@ -78,18 +78,19 @@ def test_st30p_channel(
         host=host,
         capture_cfg=capture_cfg,
     )
-    if test_config.get("integrity_check", TRUE):
+
+    if test_config.get("integrity_check", True):
         logger.info("Running audio integrity check...")
         integrity = FileAudioIntegrityRunner(
             host=host,
             test_repo_path=build,
             src_url=media_file_path,
             out_name=out_file_url.name,
+            channel_num=get_channel_number(audio_channel),
+            sample_size=get_sample_size(media_file_info["format"]),
             out_path=str(out_file_url.parent),
+            delete_file=True,
         )
         result = integrity.run()
         if not result:
-            # log_fail("Audio integrity check failed")
-            logger.warning(
-                "Integrity check failed probably because incorrect source file."
-            )
+            log_fail("Audio integrity check failed")

tests/validation/tests/single/st30p/st30p_format/test_st30p_format.py

@@ -6,6 +6,7 @@
 import pytest
 from common.integrity.integrity_runner import FileAudioIntegrityRunner
 from mtl_engine.execute import log_fail
+from mtl_engine.integrity import get_sample_size
 from mtl_engine.media_files import audio_files
 
 logger = logging.getLogger(__name__)
@@ -76,11 +77,9 @@ def test_st30p_format(
             test_repo_path=build,
             src_url=media_file_path,
             out_name=out_file_url.name,
+            sample_size=get_sample_size(media_file_info["format"]),
             out_path=str(out_file_url.parent),
         )
         result = integrity.run()
         if not result:
-            # log_fail("Audio integrity check failed")
-            logger.warning(
-                "Integrity check failed probably because incorrect source file."
-            )
+            log_fail("Audio integrity check failed")

tests/validation/tests/single/st30p/st30p_ptime/test_st30p_ptime.py

@@ -6,6 +6,7 @@
 import pytest
 from common.integrity.integrity_runner import FileAudioIntegrityRunner
 from mtl_engine.execute import log_fail
+from mtl_engine.integrity import get_sample_size
 from mtl_engine.media_files import audio_files
 
 logger = logging.getLogger(__name__)
@@ -78,11 +79,9 @@ def test_st30p_ptime(
             test_repo_path=build,
             src_url=media_file_path,
             out_name=out_file_url.name,
+            sample_size=get_sample_size(media_file_info["format"]),
             out_path=str(out_file_url.parent),
         )
         result = integrity.run()
         if not result:
-            # log_fail("Audio integrity check failed")
-            logger.warning(
-                "Integrity check failed probably because incorrect source file."
-            )
+            log_fail("Audio integrity check failed")

tests/validation/tests/single/st30p/st30p_sampling/test_st30p_sampling.py

@@ -6,6 +6,7 @@
 import pytest
 from common.integrity.integrity_runner import FileAudioIntegrityRunner
 from mtl_engine.execute import log_fail
+from mtl_engine.integrity import get_sample_number, get_sample_size
 from mtl_engine.media_files import audio_files
 
 logger = logging.getLogger(__name__)
@@ -78,11 +79,10 @@ def test_st30p_sampling(
             test_repo_path=build,
             src_url=media_file_path,
             out_name=out_file_url.name,
+            sample_size=get_sample_size(media_file_info["format"]),
+            sample_num=get_sample_number(audio_sampling, "1"),
             out_path=str(out_file_url.parent),
         )
         result = integrity.run()
         if not result:
-            # log_fail("Audio integrity check failed")
-            logger.warning(
-                "Integrity check failed probably because incorrect source file."
-            )
+            log_fail("Audio integrity check failed")