fix record_batch_reader params in geodataframe #71
+13
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In core.py, geodataframe is calling record_batch_reader incorrectly
here is the function declaration:
def record_batch_reader(
overture_type, bbox=None, release=None, connect_timeout=None, request_timeout=None, stac=False
) -> Optional[pa.RecordBatchReader]:
and here is how it's being called in geodataframe:
reader = record_batch_reader(overture_type, bbox, connect_timeout, request_timeout)
the connect_timeout is being passed through as the release and the request_timeout is being passed through as the connect_timeout, so if either of these are set it will cause unintended outcomes.