Skip to content

Conversation

@jeremy-costello
Copy link

In core.py, geodataframe is calling record_batch_reader incorrectly

here is the function declaration:

def record_batch_reader(
overture_type, bbox=None, release=None, connect_timeout=None, request_timeout=None, stac=False
) -> Optional[pa.RecordBatchReader]:

and here is how it's being called in geodataframe:

reader = record_batch_reader(overture_type, bbox, connect_timeout, request_timeout)

the connect_timeout is being passed through as the release and the request_timeout is being passed through as the connect_timeout, so if either of these are set it will cause unintended outcomes.

@jeremy-costello
Copy link
Author

Also added "release" and "stac" as inputs to geodataframe

@danabauer danabauer self-requested a review October 23, 2025 08:58
@danabauer danabauer requested a review from jwass October 23, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants