diff --git a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java index fdf973cd..2e328281 100644 --- a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java +++ b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java @@ -25,6 +25,7 @@ import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; +import java.io.FileNotFoundException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -39,11 +40,11 @@ @RestController public class VersionController { - private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName()); + private static final Logger logger = LoggerFactory.getLogger(VersionController.class); @CrossOrigin() @Operation(summary = "Get version information") - @GetMapping(value = "/version",consumes = "application/json", produces = "application/json") + @GetMapping(value = "/version", produces = "application/json") public String versionInformation() { OutputResponse output = new OutputResponse(); try { @@ -59,7 +60,10 @@ public String versionInformation() { private String readGitProperties() throws Exception { ClassLoader classLoader = getClass().getClassLoader(); InputStream inputStream = classLoader.getResourceAsStream("git.properties"); - + if (inputStream == null) { + throw new FileNotFoundException("git.properties file not found in classpath"); +} + return readFromInputStream(inputStream); } private String readFromInputStream(InputStream inputStream)