From 89ee8f0217e74c7b29ae73212ea185b62c9675bb Mon Sep 17 00:00:00 2001 From: Rishav Raj Bhagat Date: Sun, 13 Apr 2025 20:41:42 +0530 Subject: [PATCH 1/2] added some minor fixes in VersionController.java file --- .../identity/controller/version/VersionController.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java index fdf973cd..c2cdee11 100644 --- a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java +++ b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java @@ -39,11 +39,11 @@ @RestController public class VersionController { - private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName()); + private static final Logger logger = LoggerFactory.getLogger(VersionController.class); @CrossOrigin() @Operation(summary = "Get version information") - @GetMapping(value = "/version",consumes = "application/json", produces = "application/json") + @GetMapping(value = "/version", produces = "application/json") public String versionInformation() { OutputResponse output = new OutputResponse(); try { @@ -59,7 +59,10 @@ public String versionInformation() { private String readGitProperties() throws Exception { ClassLoader classLoader = getClass().getClassLoader(); InputStream inputStream = classLoader.getResourceAsStream("git.properties"); - + if (inputStream == null) { + throw new FileNotFoundException("git.properties file not found in classpath"); +} + return readFromInputStream(inputStream); } private String readFromInputStream(InputStream inputStream) From cb287ab0586fd835cc9e5b7b58b64f3806c6d4cc Mon Sep 17 00:00:00 2001 From: Rishav Raj Bhagat Date: Sun, 13 Apr 2025 20:57:26 +0530 Subject: [PATCH 2/2] added import for FileNotFound Exception --- .../common/identity/controller/version/VersionController.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java index c2cdee11..2e328281 100644 --- a/src/main/java/com/iemr/common/identity/controller/version/VersionController.java +++ b/src/main/java/com/iemr/common/identity/controller/version/VersionController.java @@ -25,6 +25,7 @@ import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; +import java.io.FileNotFoundException; import org.slf4j.Logger; import org.slf4j.LoggerFactory;