Skip to content

Commit 3f87464

Browse files
authored
refine executor_gc_helper codes, test=develop (#19814)
1 parent 6d72a86 commit 3f87464

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

paddle/fluid/framework/executor.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ struct ExecutorPrepareContext {
4444

4545
std::vector<std::unique_ptr<OperatorBase>> ops_;
4646

47-
std::unordered_map<OperatorBase*, std::vector<std::string>> unused_vars_;
47+
std::unordered_map<const OperatorBase*, std::vector<std::string>>
48+
unused_vars_;
4849
bool force_disable_gc_{false};
4950
};
5051

paddle/fluid/framework/executor_gc_helper.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ static bool VarCanBeDeleted(const std::string &name, const BlockDesc &block,
8989
type == proto::VarType::LOD_TENSOR_ARRAY;
9090
}
9191

92-
std::unordered_map<OperatorBase *, std::vector<std::string>> GetUnusedVars(
93-
const BlockDesc &block,
94-
const std::vector<std::unique_ptr<OperatorBase>> &ops,
95-
const std::vector<std::string> &skip_var_list) {
92+
std::unordered_map<const OperatorBase *, std::vector<std::string>>
93+
GetUnusedVars(const BlockDesc &block,
94+
const std::vector<std::unique_ptr<OperatorBase>> &ops,
95+
const std::vector<std::string> &skip_var_list) {
9696
std::unordered_set<std::string> skip_vars(skip_var_list.begin(),
9797
skip_var_list.end());
9898

@@ -134,7 +134,7 @@ std::unordered_map<OperatorBase *, std::vector<std::string>> GetUnusedVars(
134134
}
135135
}
136136

137-
std::unordered_map<OperatorBase *, std::vector<std::string>> result;
137+
std::unordered_map<const OperatorBase *, std::vector<std::string>> result;
138138
for (auto &name_op_idx_pair : var_op_idx_map) {
139139
auto &name = name_op_idx_pair.first;
140140
size_t op_idx = name_op_idx_pair.second;
@@ -144,8 +144,8 @@ std::unordered_map<OperatorBase *, std::vector<std::string>> GetUnusedVars(
144144
}
145145

146146
void DeleteUnusedTensors(
147-
const Scope &scope, OperatorBase *op,
148-
const std::unordered_map<OperatorBase *, std::vector<std::string>>
147+
const Scope &scope, const OperatorBase *op,
148+
const std::unordered_map<const OperatorBase *, std::vector<std::string>>
149149
&delete_vars_map,
150150
GarbageCollector *gc) {
151151
auto iter = delete_vars_map.find(op);

paddle/fluid/framework/executor_gc_helper.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ namespace paddle {
2626
namespace framework {
2727

2828
// Result map: op -> variable names that can be deleted after op runs
29-
std::unordered_map<OperatorBase *, std::vector<std::string>> GetUnusedVars(
30-
const BlockDesc &block,
31-
const std::vector<std::unique_ptr<OperatorBase>> &ops,
32-
const std::vector<std::string> &skip_vars);
29+
std::unordered_map<const OperatorBase *, std::vector<std::string>>
30+
GetUnusedVars(const BlockDesc &block,
31+
const std::vector<std::unique_ptr<OperatorBase>> &ops,
32+
const std::vector<std::string> &skip_vars);
3333

3434
// Collect unused tensors after op runs
3535
void DeleteUnusedTensors(
36-
const Scope &scope, OperatorBase *op,
37-
const std::unordered_map<OperatorBase *, std::vector<std::string>>
36+
const Scope &scope, const OperatorBase *op,
37+
const std::unordered_map<const OperatorBase *, std::vector<std::string>>
3838
&delete_vars_map,
3939
GarbageCollector *gc);
4040

0 commit comments

Comments
 (0)