Skip to content

[BIT] Fix fused_linear, fused_multi_head_attention doc #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

Cutelemon6
Copy link
Contributor

paddle.incubate.nn.functional.fused_linear

缺少 trans_x 的参数描述,为其补充。

paddle.incubate.nn.functional.fused_multi_head_attention

原来文档的有一行是这样的

out = linear(out) + qkv) + bias

看上去多打了 qkv),并且原来的描述里缺少了 qkv 的矩阵乘法,发现源码文档的伪码描述更好,但是源码文档里算完 attention score 后的线性层相关行为描述为

out = linear(out)
if add_residual:
    out = residual + dropout(out)
else:
    out = dropout(out)
# ...

和 kernel 实现不一致,在 paddle/phi/kernels/fusion/gpu/fused_attention_kernel.cu 中为了采用融合算子 fused_dropout_layernorm_helper.ResidualDropoutBias 和 fused_dropout_layernorm_helper.LayernormResidualDropoutBias,linear 是无偏的,将偏置放到了融合算子的参数里,所以改为

out = linear(out, bias=None)
if add_residual:
    out = residual + dropout(out + linear_bias)
else:
    out = dropout(out + linear_bias)

更符合算子的实现。

Copy link

paddle-bot bot commented Jun 27, 2025

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-7336.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@DrRyanHuang
Copy link
Collaborator

DrRyanHuang commented Jun 30, 2025

UPDATE:官网问题,无需补充


文档 fused_linear_cn 和文档fused_multi_head_attention的实例中有:

COPY-FROM: paddle.incubate.nn.functional.fused_linear
COPY-FROM: paddle.incubate.nn.functional.fused_multi_head_attention

辛苦同学也补充一下~

@Cutelemon6
Copy link
Contributor Author

文档 fused_linear_cn 和文档fused_multi_head_attention的实例中有:

COPY-FROM: paddle.incubate.nn.functional.fused_linear
COPY-FROM: paddle.incubate.nn.functional.fused_multi_head_attention

辛苦同学也补充一下~

我这里 pr preview 链接里的 COPY-FROM 能正常从 paddle 库里复制显示两个示例代码

但是文档网站上 develop 分支的文档不行,不知道什么原因。其它 api 在 develop 上也没有正常显示 COPY-FROM 的代码,例如 paddle.abs 但是 3.0-beta 下的 paddle.abs 是可以的 。

@luotao1 luotao1 merged commit 35d23af into PaddlePaddle:develop Jul 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants