Trader Fixes #1525
Open
Trader Fixes #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightblade
reviewed
Nov 5, 2025
| result = result .. "/" .. realm | ||
| end | ||
| result = result .. "/" .. league:gsub(" ", "+") | ||
| local encodedLeague = league:gsub("[^%w%-%.%_%~]", function(c) |
Contributor
There was a problem hiding this comment.
Any reason not to use our existing urlEncode function here?
Author
There was a problem hiding this comment.
No reason. Just add gsub(" ", "+").
Nightblade
reviewed
Nov 5, 2025
Comment on lines
81
to
91
| policies[policyName].retryAfter = os.time() + retryAfter | ||
| end | ||
| local ruleNames = {} | ||
| for match in headers["x-rate-limit-rules"]:gmatch("[^,]+") do | ||
| ruleNames[#ruleNames+1] = match:lower() | ||
| local rulesHeader = headers["x-rate-limit-rules"] | ||
| if rulesHeader and rulesHeader ~= "" then | ||
| for match in rulesHeader:gmatch("[^,]+") do | ||
| ruleNames[#ruleNames+1] = match:lower() | ||
| end | ||
| end | ||
| for _, ruleName in pairs(ruleNames) do | ||
| policies[policyName][ruleName] = {} |
Contributor
There was a problem hiding this comment.
Hi, these should be TAB indented (some more near line 249 too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Primary fix
Various fixes made along the way
Test cases
Recommendations