[ACTIONS] JIRA - Create Task - the Organizations field is not applying #17799
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update primarily consists of version number increments across numerous Jira action and source modules. Additionally, internal logic for dynamic field option fetching in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IssueAction as Jira Action (e.g., Create/Update Issue)
participant IssueModule as common/issue.mjs
participant JiraAPI
User->>IssueAction: Initiate action (e.g., create issue)
IssueAction->>IssueModule: getDynamicFields()
alt Field requires resource request
IssueModule->>JiraAPI: Fetch options via resource URL
JiraAPI-->>IssueModule: Return options
else Field requires autocomplete
IssueModule->>JiraAPI: Fetch options via autoCompleteUrl
JiraAPI-->>IssueModule: Return autocomplete options
IssueModule->>IssueModule: Map options via AUTOCOMPLETE_KEY
else Field has allowedValues
IssueModule->>IssueModule: Map allowedValues to options
end
IssueModule-->>IssueAction: Return dynamic fields/options
IssueAction-->>User: Present dynamic field options
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jcortes
force-pushed
the
fix-jira-org-field-is-not-applied
branch
from
f03737d to
2ef9043
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
components/jira/actions/get-user/get-user.mjs (1)
7-7: Same observation as previous file
Only theversionfield changed. Assuming changelog coverage is handled globally.
🧹 Nitpick comments (1)
components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (1)
60-68: Silent JSON.parse failure can mask user errors
propertiesis parsed in atry / catchthat silently swallows malformed JSON (//pass). If the input is invalid, the call silently proceeds withproperties = undefined, leaving users unaware their payload was ignored.- try { - properties = JSON.parse(this.properties); - } catch ( err ) { - //pass - } + try { + properties = JSON.parse(this.properties); + } catch (err) { + throw new Error("`properties` must be valid JSON: " + err.message); + }Surfacing the error early improves DX and prevents downstream surprises.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (27)
components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs(1 hunks)components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs(1 hunks)components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs(1 hunks)components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs(1 hunks)components/jira/actions/assign-issue/assign-issue.mjs(1 hunks)components/jira/actions/common/issue.mjs(2 hunks)components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs(1 hunks)components/jira/actions/create-issue/create-issue.mjs(1 hunks)components/jira/actions/create-version/create-version.mjs(1 hunks)components/jira/actions/delete-project/delete-project.mjs(1 hunks)components/jira/actions/get-all-projects/get-all-projects.mjs(1 hunks)components/jira/actions/get-issue/get-issue.mjs(1 hunks)components/jira/actions/get-task/get-task.mjs(1 hunks)components/jira/actions/get-transitions/get-transitions.mjs(1 hunks)components/jira/actions/get-user/get-user.mjs(1 hunks)components/jira/actions/get-users/get-users.mjs(1 hunks)components/jira/actions/list-issue-comments/list-issue-comments.mjs(1 hunks)components/jira/actions/search-issues-with-jql/search-issues-with-jql.mjs(1 hunks)components/jira/actions/transition-issue/transition-issue.mjs(1 hunks)components/jira/actions/update-comment/update-comment.mjs(1 hunks)components/jira/actions/update-issue/update-issue.mjs(1 hunks)components/jira/common/constants.mjs(2 hunks)components/jira/package.json(1 hunks)components/jira/sources/events/events.mjs(1 hunks)components/jira/sources/issue-created/issue-created.mjs(1 hunks)components/jira/sources/issue-deleted/issue-deleted.mjs(1 hunks)components/jira/sources/issue-updated/issue-updated.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
components/jira/package.json (1)
Learnt from: jcortes
PR: #14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like fs to package.json dependencies, as they are native modules provided by the Node.js runtime.
components/jira/sources/issue-deleted/issue-deleted.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/jira/sources/events/events.mjs (4)
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs, when processing items in getAndProcessData, savedIds is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The common-webhook-methods.mjs object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta and getEventType to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: #12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The common-webhook-methods.mjs object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like generateWebhookMeta and getEventType to enforce implementation in subclasses.
components/jira/sources/issue-created/issue-created.mjs (2)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: #14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In components/the_magic_drip/sources/common.mjs, when processing items in getAndProcessData, savedIds is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/jira/actions/create-issue/create-issue.mjs (1)
Learnt from: jcortes
PR: #14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In components/gainsight_px/actions/create-account/create-account.mjs, the action name should be "Create Account" instead of "Create Memory".
components/jira/sources/issue-updated/issue-updated.mjs (1)
Learnt from: GTFalcao
PR: #15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (30)
components/jira/package.json (1)
3-3: Version bump aligns with coordinated releasePatch-level increment matches the internal component bumps, so no concerns here.
components/jira/sources/issue-created/issue-created.mjs (1)
7-7: Source version increment looks correctConsistent patch bump; nothing else changed.
components/jira/actions/create-version/create-version.mjs (1)
7-7: Action version increment acknowledgedVersion
0.1.11keeps parity with sibling actions.components/jira/actions/list-issue-comments/list-issue-comments.mjs (1)
7-7: Version bump notedNo functional alterations detected—good to merge.
components/jira/actions/get-task/get-task.mjs (1)
7-7: Patch release tag verifiedVersion change only; implementation untouched.
components/jira/actions/get-all-projects/get-all-projects.mjs (1)
7-7: LGTM! Version increment aligns with coordinated release.The version bump from "0.1.11" to "0.1.12" is consistent with the coordinated release pattern across multiple Jira components in this PR.
components/jira/actions/get-transitions/get-transitions.mjs (1)
7-7: LGTM! Version increment follows coordinated release pattern.The version bump from "0.1.10" to "0.1.11" is consistent with the systematic version updates across Jira components in this release.
components/jira/common/constants.mjs (3)
20-21: LGTM! ISSUELINKS field key addition is consistent.The new
ISSUELINKS: "issuelinks"entry follows the established pattern in theFIELD_KEYconstant and supports the enhanced dynamic field functionality.
23-44: LGTM! AUTOCOMPLETE_KEY provides well-structured option extraction logic.The new
AUTOCOMPLETE_KEYconstant provides clean, structured logic for processing autocomplete responses:
assigneemapping correctly extractsdisplayNameas label andaccountIdas valueissuelinkslogic properly flattens the nestedsections.issuesstructure to extractsummaryandkeyThe implementation follows functional programming patterns and provides the foundation for improved dynamic field handling.
69-69: LGTM! AUTOCOMPLETE_KEY properly exported.The new constant is correctly added to the default export, making it available for use in other modules like the issue.mjs dynamic field logic.
components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1)
8-8: LGTM! Version increment aligns with coordinated release.The version bump from "0.0.2" to "0.0.3" is consistent with the systematic version updates across Jira action components in this PR.
components/jira/sources/issue-deleted/issue-deleted.mjs (1)
7-7: LGTM! Version increment follows coordinated release pattern.The version bump from "0.0.11" to "0.0.12" is consistent with the systematic version updates across Jira source components in this release.
components/jira/actions/delete-project/delete-project.mjs (1)
7-7: Version bump looks good.This coordinated version increment aligns with the broader update across Jira components in this PR.
components/jira/actions/common/issue.mjs (3)
126-129: Good separation of concerns for different request types.The introduction of
keysForAutoCompleteRequestprovides clear distinction between fields that need autocomplete URL requests versus resource requests.
155-168: Excellent addition for handling allowed values.This new handling for array schema types with
allowedValuesdirectly addresses cases where fields have predefined options, which could be related to the Organizations field issue mentioned in the PR.
171-192: Improved error handling and autocomplete logic.The refactored autocomplete URL handling with better error handling ensures that field processing continues even if individual autocomplete requests fail. The use of
AUTOCOMPLETE_KEY[key].getOptions(response)provides field-specific option extraction logic.components/jira/actions/assign-issue/assign-issue.mjs (1)
6-6: Version bump aligns with coordinated update.The version increment is consistent with the broader Jira components update in this PR.
components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs (1)
9-9: Appropriate patch version increment.The version bump from 1.0.2 to 1.0.3 follows semantic versioning conventions for patch releases.
components/jira/sources/events/events.mjs (1)
8-8: Source component version bump completed.This completes the coordinated version update across the Jira components suite.
components/jira/actions/get-users/get-users.mjs (1)
7-7: Version bump looks good – patch increment to0.0.6is consistent with the coordinated release across Jira components and introduces no behavioural change.components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs (1)
6-6: Patch version increment confirmed – moving to0.0.10keeps semantic-versioning continuity; nothing else modified.components/jira/actions/get-issue/get-issue.mjs (1)
7-7: Patch version bump verified –0.1.13aligns with the rest of the bundle; no logic affected.components/jira/sources/issue-updated/issue-updated.mjs (1)
7-7: Source version updated –0.0.12matches the other Jira sources; change is metadata-only.components/jira/actions/search-issues-with-jql/search-issues-with-jql.mjs (1)
7-7: Minor patch release accepted –0.0.3increment is appropriate; implementation untouched.components/jira/actions/update-comment/update-comment.mjs (1)
8-8: Version bump looks good — ensure accompanying changelog entry
Patch-level increment is appropriate given no functional changes. Please confirm a corresponding note exists in the package-level CHANGELOG to keep release history transparent.components/jira/actions/create-issue/create-issue.mjs (1)
10-10: Patch version bump acknowledged
No issues spotted. Verify that any automation relying on the action’s version (e.g., docs site or marketplace publishing) is triggered.components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs (1)
9-9: Consistent version increment
Looks fine. Remember to regenerate the component index if your build requires it.components/jira/actions/transition-issue/transition-issue.mjs (1)
8-8: Version metadata updated
No functional diff detected. Good to merge once global release notes are updated.components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (1)
8-8: Version bump looks good—confirm repository-wide consistency
Patch-level increment from0.1.10→0.1.11follows SemVer and matches the pattern in the PR. Just make sure:
components/jira/package.jsonand any changelog entries reflect the same new version.- No other files still reference
0.1.10.If those checks pass, nothing else to do here.
components/jira/actions/update-issue/update-issue.mjs (1)
11-11: Version increment acknowledged—no further issues
The bump from0.2.14→0.2.15is correct and aligns with the coordinated updates across Jira actions. Ensure accompanying docs/changelog entries are updated.
WHY
Resolves #17214
Summary by CodeRabbit
New Features
Bug Fixes
Chores