Fix 100% coverage

Author: nicholasruunu

spec/Query/GroupBySpec.php

@@ -9,40 +9,36 @@
 
 class GroupBySpec extends ObjectBehavior
 {
-    private string $alias = 'a';
-
-    private string $field = 'foo';
+    private string $field = 'a.foo';
 
     public function it_should_support_anything(): void
     {
-        $this->beConstructedWith($this->field, GroupBy::ADD_GROUP_BY, $this->alias);
+        $this->beConstructedWith($this->field, GroupBy::ADD_GROUP_BY);
 
         $this->isSatisfiedBy('foo')->shouldReturn(true);
     }
 
     public function it_calls_groupBy_on_query_builder(QueryBuilder $queryBuilder): void
     {
-        $this->beConstructedWith($this->field, GroupBy::GROUP_BY, $this->alias);
+        $this->beConstructedWith($this->field, GroupBy::GROUP_BY);
 
-        $arg = sprintf('%s.%s', $this->alias, $this->field);
-        $queryBuilder->groupBy($arg)->shouldBeCalled()->willReturn($queryBuilder);
+        $queryBuilder->groupBy($this->field)->shouldBeCalled()->willReturn($queryBuilder);
 
-        $this->modify($queryBuilder, $this->alias);
+        $this->modify($queryBuilder);
     }
 
     public function it_calls_addGroupBy_on_query_builder(QueryBuilder $queryBuilder): void
     {
-        $this->beConstructedWith($this->field, GroupBy::ADD_GROUP_BY, $this->alias);
+        $this->beConstructedWith($this->field, GroupBy::ADD_GROUP_BY);
 
-        $arg = sprintf('%s.%s', $this->alias, $this->field);
-        $queryBuilder->addGroupBy($arg)->shouldBeCalled()->willReturn($queryBuilder);
+        $queryBuilder->addGroupBy($this->field)->shouldBeCalled()->willReturn($queryBuilder);
 
-        $this->modify($queryBuilder, $this->alias);
+        $this->modify($queryBuilder);
     }
 
     public function it_throws_exception_when_setting_illegal_type(): void
     {
-        $this->beConstructedWith($this->field, 'foo', $this->alias);
+        $this->beConstructedWith($this->field, 'foo');
         $this->shouldThrow(InvalidArgumentException::class)->duringInstantiation();
     }
 }

spec/SpecificationRepositorySpec.php

@@ -92,7 +92,7 @@ public function it_should_accept_specification_with_only_query_modifiers(
 
         $specification->modify($queryBuilder, $this->dqlAlias, Argument::any())->shouldBeCalled();
         $specification->isSatisfiedBy(Argument::any())->willReturn(true);
-        $specification->modify($queryBuilder, $this->dqlAlias, Argument::any())->willReturn('');
+        $specification->modify($queryBuilder, $this->dqlAlias, Argument::any())->willReturn(null);
 
         $this->match($specification);
     }

src/Query/GroupBy.php

@@ -32,14 +32,6 @@ public function __construct(string $field, protected string $type = self::ADD_GR
         }
     }
 
-    /**
-     * @throws InvalidArgumentException
-     */
-    public function setType(string $type): self
-    {
-        return new self($this->field, $type, $this->dqlAlias);
-    }
-
     #[\Override]
     public function modify(QueryBuilder $queryBuilder, ?string $dqlAlias = null): ?string
     {

src/SpecificationRepositoryTrait.php

@@ -40,7 +40,7 @@ private function modifyQueryBuilder(QueryBuilder $queryBuilder, SpecificationInt
     {
         $condition = $specification->modify($queryBuilder, $this->dqlAlias);
 
-        if (null === $condition || '' === $condition || '0' === $condition) {
+        if (null === $condition) {
             return;
         }