Skip to content

Commit b3aec3a

Browse files
authored
react-experiment: no logger flush (#168)
* react-experiment: do not depend on logger's flush * changeset
1 parent 06505dd commit b3aec3a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.changeset/late-tools-grow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@lightmill/react-experiment': major
3+
---
4+
5+
Do not flush before completing a run, and do not require loggers to define a flush method.

packages/react-experiment/src/timeline.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ type TimelineAction<T> =
3131
export type Logger = {
3232
startRun(): Promise<void>;
3333
addLog(log: RegisteredLog): Promise<void>;
34-
flush(): Promise<void>;
3534
completeRun(): Promise<void>;
3635
cancelRun?(): Promise<void>;
3736
};
@@ -117,7 +116,6 @@ export default function useManagedTimeline<Task extends BaseTask>(
117116
});
118117
if (hasEnded) return;
119118
dispatch({ type: 'all-tasks-completed' });
120-
await logger?.flush();
121119
await logger?.completeRun();
122120
if (hasEnded) return;
123121
dispatch({ type: 'run-completed' });

0 commit comments

Comments
 (0)