From ca33929f26a2695aac99624d66fb05e8cb84564e Mon Sep 17 00:00:00 2001 From: Nick Papior Date: Mon, 27 Jan 2025 09:55:10 +0100 Subject: [PATCH 1/2] fixed #73 force allow-argument-mismatch For GCC >= 10 compilers we now forcefully add the allow-argument-mismatch flag which is required for it to be compiled. It will change errors into warnings for routines called with non-conforming type arguments. Signed-off-by: Nick Papior --- CMakeLists.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index bdd42da8..26ca9f22 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -77,6 +77,15 @@ if (UNIX) endif () endif () + +if(CMAKE_Fortran_COMPILER_ID MATCHES GNU) + if(CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10.0) + # Fixes #73, ensure fallow-argument-mismatch is present for GCC >= 10 releases + message(STATUS "Adding '-fallow-argument-mismatch' for GNU >= 10.0") + set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch") + endif() +endif() + macro(SCALAPACK_install_library lib) install(TARGETS ${lib} EXPORT scalapack-targets ARCHIVE DESTINATION lib${LIB_SUFFIX} From 8c3d69d5d93a4e6c7a5015b68ce4194282dd9640 Mon Sep 17 00:00:00 2001 From: Mark Gates Date: Wed, 11 Jun 2025 11:34:32 -0400 Subject: [PATCH 2/2] style: ScaLAPACK's CMakeLists uses 3-space indent, same as Fortran code --- CMakeLists.txt | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 26ca9f22..dce48db8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -77,13 +77,12 @@ if (UNIX) endif () endif () - -if(CMAKE_Fortran_COMPILER_ID MATCHES GNU) - if(CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10.0) - # Fixes #73, ensure fallow-argument-mismatch is present for GCC >= 10 releases - message(STATUS "Adding '-fallow-argument-mismatch' for GNU >= 10.0") - set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch") - endif() +if (CMAKE_Fortran_COMPILER_ID MATCHES GNU) + if (CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10.0) + # Fixes #73, ensure fallow-argument-mismatch is present for GCC >= 10 releases + message(STATUS "Adding '-fallow-argument-mismatch' for GNU >= 10.0") + set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch") + endif() endif() macro(SCALAPACK_install_library lib)