-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Why do we need this ?
As a GitHub App developer
I need to:
- Alter/Add Extra information to the Block Notification Send when user runs commands (list mentioned) which needs authentication while not being loggedin.
Command List:
- View your GitHub Profile and Issues -> /github me
- View/Add/Delete/Update Repository Subscriptions -> /github subscribe
- Subscribe to all repository events -> /github Username/RepositoryName subscribe
- Unsubscribe to all repository events -> /github Username/RepositoryName unsubscribe
- Add New Issues to GitHub Repository -> /github issue
- Assign and Share Issues -> /github issues
- So Currently when we run above command for eg for subscribing events we get Notification that
Login to subscribe to repository events ! /github login
but what we want is and will more helpful: We send Login ActionButton attaching to that same Block while having the MessageYou must be LoggedIn to subscribe repository events. Login to Github
.
So That: We will save the key strokes for users to not run command /github login
Glimpses of what should look like:
Acceptance Criteria
- Alter and Add to same Notify Block with LoginButtons for all commands mention
Further Comments / References
- Also to Note we will have different messages the one that i mention was just for the subscribe event.
- To note we also have ActionsButtons within Modal which needs authentications dont forget to look for same.
Additional comments
- Apart from that we have one know bug (when writing this issue): When we run
/github Username/RepositoryName subscribe
without loggedin we ain't getting any message if we are not loggedIn. which has/ have been fixed [FIX] subscribeall doesn't provide info when not loggedIn #63. which currently provides the simple loginInfo make sure to change it when merging this.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request