Migrate from onelogin namespace to python3_saml namespace
#441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid conflicting with onelogin BREAKING CHANGE: imports will need to be changed from `from onelogin.<path> import ...` to `from python3_saml.<path> import ...`
chore(INFRA-831): move application to a new namespace (python3_saml) to avoid conflicting with onelogin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any code base depending on both the
python3-samlandoneloginpackages are not able to use the latest versions of both packages. In particular, it is not possible to usepython3-saml>1.14.0oronelogin>3.1.6because of the conflictingonelogin.saml2.authpackage and the import ofonelogin.apiin onelogin's top level__init__.py.This can be mitigated by users by installing one or both in their own separate prefixes and manipulating the order of these prefixes in the PYTHONPATH at the beginning of any files which depend on either (but not both) package. However, this is clunky and error prone and can be fixed upstream by changing the import path of python3-saml from
onelogin.<package>topython3_saml.<package>.Also, there is a HIGH CVE in xmlsec and lxml that requires updating python3-saml to 1.16.0 to mitigate unless we want to build them from source every time we build a container.
This PR migrates all packages. tests, demos, build files, and the readme to use
python3_saml. Thedocsdirectory has been ignored since that is (maybe?) autogenerated from some other source, but I can update the docs as well if you are amenable to this change. It would be a breaking change for all consumers requiring a 2.0.0 release, but I suspect it would be a welcome one.