Skip to content

Commit f8d98dd

Browse files
authored
Merge pull request #67 from SURFnet/feature/missing-logo
Allow for missing logo's
2 parents b3ff112 + 2fa0714 commit f8d98dd

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

client/src/routes/Intake.svelte

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,9 @@
128128

129129
<!-- <span>{$offering.homeInstitution.name}</span>-->
130130
</div>
131-
<img src={$offering.homeInstitution.logoURI} alt=""/>
131+
{#if $offering.guestInstitution.logoURI}
132+
<img src={$offering.homeInstitution.logoURI} alt=""/>
133+
{/if}
132134
</div>
133135
<div class="institution">
134136
<div class="institution-detail">
@@ -144,7 +146,9 @@
144146

145147
<!-- <span>{$offering.guestInstitution.name}</span>-->
146148
</div>
147-
<img src={$offering.guestInstitution.logoURI} alt=""/>
149+
{#if $offering.guestInstitution.logoURI}
150+
<img src={$offering.guestInstitution.logoURI} alt=""/>
151+
{/if}
148152
</div>
149153
<p>Offering ID</p>
150154
<span class="info">The unique identifier of the cours / offering</span>

client/src/routes/Results.svelte

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,9 @@
144144
selectedValue={$offering.homeInstitution}
145145
isDisabled={true}/>
146146
</div>
147-
<img src={$offering.homeInstitution.logoURI} alt=""/>
147+
{#if $offering.homeInstitution.logoURI}
148+
<img src={$offering.homeInstitution.logoURI} alt=""/>
149+
{/if}
148150
</div>
149151
<div class="institution">
150152
<div class="institution-detail">
@@ -157,7 +159,9 @@
157159
selectedValue={$offering.guestInstitution}
158160
isDisabled={true}/>
159161
</div>
160-
<img src={$offering.guestInstitution.logoURI} alt=""/>
162+
{#if $offering.guestInstitution.logoURI}
163+
<img src={$offering.guestInstitution.logoURI} alt=""/>
164+
{/if}
161165
</div>
162166
{#if !$offering.associationId}
163167
<p>Association</p>

client/src/routes/ResultsV4.svelte

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@
123123
selectedValue={$offering.homeInstitution}
124124
isDisabled={true}/>
125125
</div>
126-
<img src={$offering.homeInstitution.logoURI} alt=""/>
126+
{#if $offering.homeInstitution.logoURI}
127+
<img src={$offering.homeInstitution.logoURI} alt=""/>
128+
{/if}
127129
</div>
128130
<div class="institution">
129131
<div class="institution-detail">
@@ -136,7 +138,9 @@
136138
selectedValue={$offering.guestInstitution}
137139
isDisabled={true}/>
138140
</div>
139-
<img src={$offering.guestInstitution.logoURI} alt=""/>
141+
{#if $offering.guestInstitution.logoURI}
142+
<img src={$offering.guestInstitution.logoURI} alt=""/>
143+
{/if}
140144
</div>
141145
<p>Results</p>
142146
<span class="info">It's either very good or very bad</span>

0 commit comments

Comments
 (0)