Skip to content

[🚀 Feature]: Support more container registries #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjshoe opened this issue Apr 21, 2025 · 8 comments
Open

[🚀 Feature]: Support more container registries #2798

jjshoe opened this issue Apr 21, 2025 · 8 comments

Comments

@jjshoe
Copy link

jjshoe commented Apr 21, 2025

Feature and motivation

Dockerhub has rate limits, and they are reasonable for grabbing just the selenium container. However you have to consider most modern environments where automation is king. This means many other containers are being pulled from dockerhub, many times a day, from all over inside an organization by CI/CD. The limit can quickly be hit by an extensive build job. It's not uncommon to hit rate limits, that don't exist on other registries, regularly with dockerhub.

Pushing to Github Container Registry, or Amazon pubilc ECR should be very trivial to do with the existing selenium pipeline. Unlike a previous closed issue on this repository said, no one has to update any of their code to switch registries. The suggestion is to add repositories, not replace.

Adding this flexibility also gives options in the case of outages with a particular registry.

CC: #1401

Usage example

Cases where this helps:

  • Outages
  • Rate limits
  • Proximity to compute (aws)
Copy link

@jjshoe, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@VietND96
Copy link
Member

The current GitHub plan is free, so we just worry about the storage limits for the long term. As storage usage could be seen in Docker Hub, it is up to Terabytes.

Image

I think if a popular provider can sponsor us with an open-source plan for publishing images (unlimited storage), then we can push images and let users have more choices to use.

@jjshoe
Copy link
Author

jjshoe commented Apr 22, 2025

@VietND96 - https://docs.docker.com/docker-hub/repos/manage/trusted-content/official-images/ - If you work on becoming an official image in dockerhub, AWS automatically mirrors all of them https://aws.amazon.com/blogs/containers/docker-official-images-now-available-on-amazon-elastic-container-registry-public/

This seems like win win for everyone. I have not made an issue over in https://github.com/docker-library/official-images. It seems like that would be best made by someone from the selenium project. If you do make one, I would love to thumbs up it.

@VietND96
Copy link
Member

Thanks for your info here. Let me try to work on upgrading "Official Images" to see how they respond.

@diemol
Copy link
Member

diemol commented Apr 22, 2025

I believe an official image for Docker is an image with a single purpose (or something like that). Our images have different purposes and components and that's why it was not possible to make them official. I've had meetings with folks from Docker and what he have so far is that Docker Selenium is a OSS sponsored project. IIRC, that means there are no quotas when pulling our images.

@diemol
Copy link
Member

diemol commented Apr 22, 2025

@jjshoe have you hit any rate limits? I think our images don't have them.

@jjshoe
Copy link
Author

jjshoe commented Apr 22, 2025

@jjshoe have you hit any rate limits? I think our images don't have them.

I have absolutely hit rate limits, rate limits is also only one of three bullet points.

@diemol
Copy link
Member

diemol commented Apr 22, 2025

Are you authenticating when pulling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants