-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[🚀 Feature]: Support more container registries #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jjshoe, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
@VietND96 - https://docs.docker.com/docker-hub/repos/manage/trusted-content/official-images/ - If you work on becoming an official image in dockerhub, AWS automatically mirrors all of them https://aws.amazon.com/blogs/containers/docker-official-images-now-available-on-amazon-elastic-container-registry-public/ This seems like win win for everyone. I have not made an issue over in https://github.com/docker-library/official-images. It seems like that would be best made by someone from the selenium project. If you do make one, I would love to thumbs up it. |
Thanks for your info here. Let me try to work on upgrading "Official Images" to see how they respond. |
I believe an official image for Docker is an image with a single purpose (or something like that). Our images have different purposes and components and that's why it was not possible to make them official. I've had meetings with folks from Docker and what he have so far is that Docker Selenium is a OSS sponsored project. IIRC, that means there are no quotas when pulling our images. |
@jjshoe have you hit any rate limits? I think our images don't have them. |
I have absolutely hit rate limits, rate limits is also only one of three bullet points. |
Are you authenticating when pulling? |
Feature and motivation
Dockerhub has rate limits, and they are reasonable for grabbing just the selenium container. However you have to consider most modern environments where automation is king. This means many other containers are being pulled from dockerhub, many times a day, from all over inside an organization by CI/CD. The limit can quickly be hit by an extensive build job. It's not uncommon to hit rate limits, that don't exist on other registries, regularly with dockerhub.
Pushing to Github Container Registry, or Amazon pubilc ECR should be very trivial to do with the existing selenium pipeline. Unlike a previous closed issue on this repository said, no one has to update any of their code to switch registries. The suggestion is to add repositories, not replace.
Adding this flexibility also gives options in the case of outages with a particular registry.
CC: #1401
Usage example
Cases where this helps:
The text was updated successfully, but these errors were encountered: