Removed automatically search for currency setting. The currency exchange data is more accurate.

Author: leMicin

src/Sidekick.Common/Settings/DefaultSettings.cs

@@ -47,8 +47,6 @@ public static class DefaultSettings
 
     public static bool PriceCheckAutomaticallySearch => false;
 
-    public static bool PriceCheckAutomaticallySearchCurrency => false;
-
     public static bool PriceCheckEnableAllFilters => false;
 
     public static string PriceCheckEnableFiltersByRegex => "";
@@ -59,8 +57,6 @@ public static class DefaultSettings
 
     public static int PriceCheckBulkMinimumStock => 5;
 
-    public static string PriceCheckCurrencyMode => "item";
-
     public static string? PriceCheckCurrency => null;
 
     public static string? PriceCheckCurrencyPoE2 => null;

src/Sidekick.Common/Settings/SettingKeys.cs

@@ -48,14 +48,12 @@ public static class SettingKeys
     public const string PriceCheckItemCurrencyMax = nameof(PriceCheckItemCurrencyMax);
     public const string PriceCheckItemCurrencyMaxPoE2 = nameof(PriceCheckItemCurrencyMaxPoE2);
     public const string PriceCheckBulkMinimumStock = nameof(PriceCheckBulkMinimumStock);
-    public const string PriceCheckCurrencyMode = nameof(PriceCheckCurrencyMode);
     public const string PriceCheckNormalizeValue = nameof(PriceCheckNormalizeValue);
     public const string PriceCheckCompactMode = nameof(PriceCheckCompactMode);
     public const string PriceCheckSidebarWidth = nameof(PriceCheckSidebarWidth);
     public const string PriceCheckStatus = nameof(PriceCheckStatus);
     public const string PriceCheckItemClassFilter = nameof(PriceCheckItemClassFilter);
     public const string PriceCheckAutomaticallySearch = nameof(PriceCheckAutomaticallySearch);
-    public const string PriceCheckAutomaticallySearchCurrency = nameof(PriceCheckAutomaticallySearchCurrency);
     public const string PriceCheckEnableAllFilters = nameof(PriceCheckEnableAllFilters);
     public const string PriceCheckEnableFiltersByRegex = nameof(PriceCheckEnableFiltersByRegex);
     public const string PriceCheckDefaultFilterType = nameof(PriceCheckDefaultFilterType);

src/Sidekick.Modules.Trade/Localization/TradeResources.fr.resx

@@ -226,9 +226,6 @@ Cliquez sur le bouton pour l'ouvrir dans votre navigateur.</value>
   <data name="Minimum_Stock_in_Bulk_Trade" xml:space="preserve">
     <value>Stock disponible de la vente en gros</value>
   </data>
-  <data name="Preferred_search_mode_for_currency_items" xml:space="preserve">
-    <value>Mode de recherche pour les devises</value>
-  </data>
   <data name="Currency_of_Results" xml:space="preserve">
     <value>Devise des résultats</value>
   </data>
@@ -280,9 +277,6 @@ Cliquez sur le bouton pour l'ouvrir dans votre navigateur.</value>
   <data name="PriceCheck_Automatically_Search" xml:space="preserve">
     <value>Rechercher automatiquement lors de la vérification du prix</value>
   </data>
-  <data name="PriceCheck_Automatically_Search_Currency" xml:space="preserve">
-    <value>Rechercher automatiquement les devises lors de la vérification du prix</value>
-  </data>
   <data name="Setting_Rate_Limit_Hint" xml:space="preserve">
     <value>Il est recommandé de laisser désactivé afin de ne pas dépasser la limite de taux de l'API.</value>
   </data>

src/Sidekick.Modules.Trade/Localization/TradeResources.ko.resx

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
-    Microsoft ResX Schema 
-    
+  <!--
+    Microsoft ResX Schema
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-    
+
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -186,9 +186,6 @@
   <data name="PriceCheck_Automatically_Load_More_Data" xml:space="preserve">
     <value />
   </data>
-  <data name="PriceCheck_Automatically_Search_Currency" xml:space="preserve">
-    <value />
-  </data>
   <data name="Setting_Rate_Limit_Hint" xml:space="preserve">
     <value />
   </data>

src/Sidekick.Modules.Trade/Localization/TradeResources.resx

@@ -226,9 +226,6 @@ Click the button to open in your browser.</value>
   <data name="Minimum_Stock_in_Bulk_Trade" xml:space="preserve">
     <value>Minimum Stock in Bulk Trade</value>
   </data>
-  <data name="Preferred_search_mode_for_currency_items" xml:space="preserve">
-    <value>Preferred search mode for currency items</value>
-  </data>
   <data name="Currency_of_Results" xml:space="preserve">
     <value>Currency of Results</value>
   </data>
@@ -283,9 +280,6 @@ Click the button to open in your browser.</value>
   <data name="PriceCheck_Automatically_Search" xml:space="preserve">
     <value>Automatically search for items when price checking</value>
   </data>
-  <data name="PriceCheck_Automatically_Search_Currency" xml:space="preserve">
-    <value>Automatically search for currencies when price checking</value>
-  </data>
   <data name="Setting_Rate_Limit_Hint" xml:space="preserve">
     <value>It is recommended to leave disabled to avoid exceeding the API rate limit.</value>
   </data>

src/Sidekick.Modules.Trade/Settings/PriceCheckCurrencyModeEditor.razor

@@ -28,9 +28,7 @@
 <FormFieldset Legend="@Resources["Behaviour_Settings"]">
     <AlertInfo>@Resources["Rate_Limit_Disclaimer"]</AlertInfo>
     <SettingCheckboxEditor SettingKey="@SettingKeys.PriceCheckAutomaticallySearch" Label="@Resources["PriceCheck_Automatically_Search"]" Tooltip="@Resources["Setting_Rate_Limit_Hint"]"/>
-    <SettingCheckboxEditor SettingKey="@SettingKeys.PriceCheckAutomaticallySearchCurrency" Label="@Resources["PriceCheck_Automatically_Search_Currency"]" Tooltip="@Resources["Setting_Rate_Limit_Hint"]"/>
     <SettingCheckboxEditor SettingKey="@SettingKeys.PriceCheckAutomaticallyLoadMoreData" Label="@Resources["PriceCheck_Automatically_Load_More_Data"]" Tooltip="@Resources["Setting_Rate_Limit_Hint"]"/>
-    <PriceCheckCurrencyModeEditor/>
 </FormFieldset>
 
 <div class="flex justify-center mb-1">
@@ -53,13 +51,10 @@
         SettingKeys.PriceCheckNormalizeValue,
         SettingKeys.PriceCheckPredictionEnabled,
         SettingKeys.PriceCheckAutomaticallySearch,
-        SettingKeys.PriceCheckAutomaticallySearchCurrency,
         SettingKeys.PriceCheckEnableAllFilters,
         SettingKeys.PriceCheckEnableFiltersByRegex,
         SettingKeys.PriceCheckAutomaticallyLoadMoreData,
         SettingKeys.PriceCheckDefaultFilterType,
-
-        SettingKeys.PriceCheckCurrencyMode,
     };
 
     protected override async Task OnInitializedAsync()

src/Sidekick.Modules.Trade/Settings/SettingsContent.razor

@@ -7,7 +7,6 @@
 @using Sidekick.Apis.Poe.Trade.Parser.Pseudo.Filters
 @using Sidekick.Common.Settings
 @using Sidekick.Modules.Trade.Localization
-@using Sidekick.Modules.Trade.PoeNinja
 @using Sidekick.Modules.Trade.PoePrices
 @using Sidekick.Modules.Trade.Trade.Filters.Properties
 @using ItemHeader = Sidekick.Common.Ui.Poe.Items.ItemHeader
@@ -93,22 +92,15 @@
         ModifierFilters = await ModifierParser.GetFilters(Item);
         PseudoFilters = PseudoParser.GetFilters(Item);
 
-        var automaticallyPriceCheckSettingKey = Item.Properties.Rarity == Rarity.Currency ?
-            SettingKeys.PriceCheckAutomaticallySearchCurrency :
-            SettingKeys.PriceCheckAutomaticallySearch;
-        var automaticallyPriceCheck = await SettingsService.GetBool(automaticallyPriceCheckSettingKey);
+        var automaticallyPriceCheck = false;
+        if (Item.Properties.Rarity != Rarity.Currency)
+        {
+            automaticallyPriceCheck = await SettingsService.GetBool(SettingKeys.PriceCheckAutomaticallySearch);
+        }
+
         if (automaticallyPriceCheck)
         {
-            var mode = TradeMode.Item;
-            if (BulkTradeService.SupportsBulkTrade(Item))
-            {
-                mode = await SettingsService.GetEnum<TradeMode>(SettingKeys.PriceCheckCurrencyMode) ?? TradeMode.Item;
-            }
-
-            if (mode == TradeMode.Bulk)
-                await TradeService.SearchBulk(Item);
-            else
-                await TradeService.SearchItems(Item, PropertyFilters, ModifierFilters, PseudoFilters);
+            await TradeService.SearchItems(Item, PropertyFilters, ModifierFilters, PseudoFilters);
         }
         else
         {