3.3.1

Author: André Rosa

README.md

@@ -2,7 +2,7 @@ Android Quality Verifier
 ===============
 
 Static code analysis plugin for Android projects.
-This is a fork of [the original android-check plugin][1], which implements a really useful concept, but unfortunately seems abandoned.
+This is a fork of [the original android-check plugin][1], which implements a really useful concept.
 
 <!---
 Build status
@@ -30,7 +30,7 @@ The default one.
 
 ```
 // Configuration is completely optional, defaults will be used if not present
-verifier {
+check {
   // Do absolutely nothing, default: false
   skip true/false
   // Fails build if a violation is found, default: true
@@ -74,7 +74,7 @@ verifier {
   }
   
   // Lint configuration
-    lint {
+    alint {
       // Same options as Checkstyle and FindBugs, except for a couple of defaults:
   
       // Configuration file for CheckStyle, default: <project_path>/config/pmd.xml, if non-existent then <project_path>/<module_path>/config/pmd.xml, if non-existent then plugin/src/main/resources/pmd/conf-default.xml

plugin/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'groovy'
 repositories { jcenter() }
 
 dependencies {
-    compile gradleApi()
+    compileOnly gradleApi()
     // Checkstyle
     compile('com.puppycrawl.tools:checkstyle:7.6.1') {
         // Android Lint also depends on guava, so don't bring it in twice
@@ -12,7 +12,7 @@ dependencies {
     // FindBugs
     compile 'com.google.code.findbugs:findbugs:3.0.1'
     // PMD
-    compile 'net.sourceforge.pmd:pmd-java:5.5.5'
+    compile 'net.sourceforge.pmd:pmd-java:5.6.0'
 }
 
 project.ext {
@@ -21,7 +21,7 @@ project.ext {
     description = 'Static code analysis plugin for Android projects.'
     groupId = 'pt.simdea.verifier'
     artifactId = 'verifier'
-    version = "3.3.0"
+    version = "3.3.1"
     website = 'https://github.com/simdea/android-quality-verifier'
     scm = 'https://github.com/simdea/android-quality-verifier'
     tags = ['android', 'verifier', 'check', 'checkstyle', 'findbugs', 'pmd', 'lint', 'quality']

plugin/src/main/groovy/pt/simdea/verifier/CheckExtension.groovy

@@ -8,7 +8,7 @@ import pt.simdea.verifier.pmd.PmdConfig
 
 class CheckExtension {
 
-    static final String NAME = 'verifier'
+    static final String NAME = 'check'
 
     private final Project project
 

plugin/src/main/groovy/pt/simdea/verifier/CheckPlugin.groovy

@@ -10,16 +10,17 @@ class CheckPlugin implements Plugin<Project> {
 
     @Override
     void apply(Project target) {
-        target.extensions.create(CheckExtension.NAME, CheckExtension, target)
+        target.extensions.create(CheckExtension.NAME, CheckExtension)
         target.check.extensions.create('lint', CheckExtension.Lint)
 
-        new CheckstyleCheck().apply(target)
-        new FindbugsCheck().apply(target)
-        new PmdCheck().apply(target)
         target.subprojects { subProject ->
             afterEvaluate {
                 def extension = target.check
 
+                new CheckstyleCheck().apply(subProject)
+                new FindbugsCheck().apply(subProject)
+                new PmdCheck().apply(subProject)
+
                 addLint(subProject, extension)
             }
         }

plugin/src/main/groovy/pt/simdea/verifier/CommonCheck.groovy

@@ -81,8 +81,8 @@ abstract class CommonCheck<Config extends CommonConfig> {
         if (target.tasks.find({ it.name == 'check' }) != null) {
             target.tasks.getByName('check').dependsOn taskName
         } else {
-            target.logger.warn """task check not found in project $target.name. You may need to run
-                                the plugin tasks manually"""
+            target.logger.warn "task check not found in" +
+                    " project $target.name. You may need to run the plugin tasks manually"
         }
         dependencies.each { target.tasks.getByName(taskName).dependsOn it }
     }

plugin/src/main/resources/pmd/conf-default.xml

@@ -34,6 +34,7 @@ Severity: HARD
     <rule ref="rulesets/java/comments.xml">
         <exclude name="CommentRequired"/>
         <exclude name="CommentSize"/>
+        <exclude name="CommentDefaultAccessModifier"/>
     </rule>
 
     <rule ref="rulesets/java/controversial.xml">
@@ -45,6 +46,8 @@ Severity: HARD
         <exclude name="DataflowAnomalyAnalysis"/>
         <exclude name="NullAssignment"/>
         <exclude name="OnlyOneReturn"/>
+        <exclude name="AvoidFinalLocalVariable"/>
+        <exclude name="UseConcurrentHashMap"/>
     </rule>
 
     <rule ref="rulesets/java/coupling.xml">
@@ -101,7 +104,11 @@ Severity: HARD
         <exclude name="LooseCoupling"/>
     </rule>
 
-    <rule ref="rulesets/java/unnecessary.xml"/>
+    <rule ref="rulesets/java/unnecessary.xml">
+        <exclude name="UselessOverridingMethod"/>
+        <exclude name="UselessParentheses"/>
+        <exclude name="UnnecessaryModifier"/>
+    </rule>
 
     <rule ref="rulesets/java/unusedcode.xml"/>
 

plugin/src/main/resources/pmd/pmd.xsl

@@ -155,4 +155,4 @@
         </xsl:attribute>
     </xsl:template>
 
-</xsl:stylesheet>
+</xsl:stylesheet>

sample/app/build.gradle

@@ -1,5 +1,5 @@
 apply plugin: 'com.android.application'
-apply plugin: 'org.stoyicker.android-check'
+apply plugin: 'pt.simdea.verifier'
 
 android {
     compileSdkVersion 25
@@ -29,7 +29,7 @@ dependencies {
     compile 'com.github.tony19:logback-android-classic:1.1.1-4'
 }
 
-check {
+verifier {
     abortOnError true
 
     checkstyle {