v116.0.0

Author: liayn

.editorconfig

@@ -13,18 +13,22 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 # TS/JS-Files
-[*.{ts,js}]
+[*.{ts,js,mjs}]
 indent_size = 2
 
 # JSON-Files
 [*.json]
 indent_style = tab
 
 # ReST-Files
-[*.rst]
+[*.{rst,rst.txt}]
 indent_size = 4
 max_line_length = 80
 
+# Markdown-Files
+[*.md]
+max_line_length = 80
+
 # YAML-Files
 [*.{yaml,yml}]
 indent_size = 2
@@ -34,6 +38,10 @@ indent_size = 2
 indent_size = 2
 indent_style = tab
 
+# stylelint
+[.stylelintrc]
+indent_size = 2
+
 # package.json
 [package.json]
 indent_size = 2

.gitignore

@@ -1,15 +1,12 @@
 *~
 *.bak
-*.map
 .DS_Store
+/.Build/
+/node_modules/
 /composer.lock
 /.php-cs-fixer.cache
 /.php-cs-fixer.php
-
-/.Build/
-/node_modules/
-
-# Sonar Lint
-.idea/sonarlint
+/.phpunit.result.cache
+/phpstan.neon
 
 /Resources/Private/MailTemplates/app.css

.php-cs-fixer.dist.php

@@ -19,34 +19,19 @@
     )
     ->setRiskyAllowed(true)
     ->setRules([
-        '@PSR12' => true,
         '@DoctrineAnnotation' => true,
-        '@PER-CS' => true,
-        'array_syntax' => ['syntax' => 'short'],
-        'blank_line_after_opening_tag' => true,
-        'single_space_around_construct' => true,
-        'control_structure_braces' => true,
-        'control_structure_continuation_position' => true,
-        'declare_parentheses' => true,
-        'statement_indentation' => true,
-        'no_multiple_statements_per_line' => true,
+        '@PER-CS2.0' => true,
+        '@PHP82Migration' => true,
         'cast_spaces' => ['space' => 'none'],
-        'compact_nullable_type_declaration' => true,
-        'concat_space' => ['spacing' => 'one'],
-        'declare_equal_normalize' => ['space' => 'none'],
+        'declare_parentheses' => true,
         'dir_constant' => true,
-        'type_declaration_spaces' => true,
-        'lowercase_cast' => true,
-        'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],
         'modernize_types_casting' => true,
         'native_function_casing' => true,
-        'new_with_parentheses' => true,
         'no_alias_functions' => true,
         'no_blank_lines_after_phpdoc' => true,
         'no_empty_phpdoc' => true,
         'no_empty_statement' => true,
         'no_extra_blank_lines' => true,
-        'no_leading_import_slash' => true,
         'no_leading_namespace_whitespace' => true,
         'no_null_property_initialization' => true,
         'no_short_bool_cast' => true,
@@ -57,23 +42,20 @@
         'no_unused_imports' => true,
         'no_useless_else' => true,
         'no_useless_nullsafe_operator' => true,
-        'no_whitespace_in_blank_line' => true,
-        'ordered_imports' => true,
+        'ordered_imports' => ['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha'],
         'php_unit_construct' => ['assertions' => ['assertEquals', 'assertSame', 'assertNotEquals', 'assertNotSame']],
         'php_unit_mock_short_will_return' => true,
         'php_unit_test_case_static_method_calls' => ['call_type' => 'self'],
-        'phpdoc_no_access' => true,
         'phpdoc_no_empty_return' => true,
         'phpdoc_no_package' => true,
         'phpdoc_scalar' => true,
         'phpdoc_trim' => true,
         'phpdoc_types' => true,
         'phpdoc_types_order' => ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none'],
-        'return_type_declaration' => ['space_before' => 'none'],
-        'single_quote' => true,
         'single_line_comment_style' => ['comment_types' => ['hash']],
-        'single_trait_insert_per_statement' => true,
-        'trailing_comma_in_multiline' => ['elements' => ['arrays']],
+        'single_quote' => true,
+        'single_space_around_construct' => true,
+        'type_declaration_spaces' => true,
         'whitespace_after_comma_in_array' => ['ensure_single_space' => true],
         'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
     ]);

.phpstorm.meta.php

@@ -3,13 +3,10 @@
 /**
  * Extend PhpStorms code completion capabilities by providing a meta file
  *
- * Kudos to Alexander Schnitzler's work, see https://github.com/alexanderschnitzler/phpstorm.meta.php-typo3
  * @link https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html
  */
 
 namespace PHPSTORM_META {
-    // Contexts
-    // @see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/9.4/Feature-85389-ContextAPIForConsistentDataHandling.html
     expectedArguments(
         \TYPO3\CMS\Core\Context\Context::getAspect(),
         0,
@@ -21,7 +18,6 @@
         'language',
         'typoscript'
     );
-
     override(\TYPO3\CMS\Core\Context\Context::getAspect(), map([
         'date' => \TYPO3\CMS\Core\Context\DateTimeAspect::class,
         'visibility' => \TYPO3\CMS\Core\Context\VisibilityAspect::class,
@@ -31,7 +27,6 @@
         'language' => \TYPO3\CMS\Core\Context\LanguageAspect::class,
         'typoscript' => \TYPO3\CMS\Core\Context\TypoScriptAspect::class,
     ]));
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\DateTimeAspect::get(),
         0,
@@ -41,15 +36,13 @@
         'full',
         'accessTime'
     );
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\VisibilityAspect::get(),
         0,
         'includeHiddenPages',
         'includeHiddenContent',
         'includeDeletedRecords'
     );
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\UserAspect::get(),
         0,
@@ -60,15 +53,13 @@
         'groupIds',
         'groupNames'
     );
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\WorkspaceAspect::get(),
         0,
         'id',
         'isLive',
         'isOffline'
     );
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\LanguageAspect::get(),
         0,
@@ -79,7 +70,6 @@
         'legacyLanguageMode',
         'legacyOverlayType'
     );
-
     expectedArguments(
         \TYPO3\CMS\Core\Context\TypoScriptAspect::get(),
         0,
@@ -89,41 +79,47 @@
     expectedArguments(
         \Psr\Http\Message\ServerRequestInterface::getAttribute(),
         0,
-        'backend.user',
         'frontend.user',
         'normalizedParams',
         'site',
         'language',
-        'routing'
+        'routing',
+        'module',
+        'moduleData',
+        'frontend.controller',
+        'frontend.typoscript',
     );
-
     override(\Psr\Http\Message\ServerRequestInterface::getAttribute(), map([
-        'backend.user' => \TYPO3\CMS\Backend\FrontendBackendUserAuthentication::class,
         'frontend.user' => \TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication::class,
         'normalizedParams' => \TYPO3\CMS\Core\Http\NormalizedParams::class,
         'site' => \TYPO3\CMS\Core\Site\Entity\SiteInterface::class,
         'language' => \TYPO3\CMS\Core\Site\Entity\SiteLanguage::class,
         'routing' => '\TYPO3\CMS\Core\Routing\SiteRouteResult|\TYPO3\CMS\Core\Routing\PageArguments',
+        'module' => \TYPO3\CMS\Backend\Module\ModuleInterface::class,
+        'moduleData' => \TYPO3\CMS\Backend\Module\ModuleData::class,
+        'frontend.controller' => \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::class,
+        'frontend.typoscript' => \TYPO3\CMS\Core\TypoScript\FrontendTypoScript::class,
     ]));
 
     expectedArguments(
         \TYPO3\CMS\Core\Http\ServerRequest::getAttribute(),
         0,
-        'backend.user',
         'frontend.user',
         'normalizedParams',
         'site',
         'language',
-        'routing'
+        'routing',
+        'module',
+        'moduleData'
     );
-
     override(\TYPO3\CMS\Core\Http\ServerRequest::getAttribute(), map([
-        'backend.user' => \TYPO3\CMS\Backend\FrontendBackendUserAuthentication::class,
         'frontend.user' => \TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication::class,
         'normalizedParams' => \TYPO3\CMS\Core\Http\NormalizedParams::class,
         'site' => \TYPO3\CMS\Core\Site\Entity\SiteInterface::class,
         'language' => \TYPO3\CMS\Core\Site\Entity\SiteLanguage::class,
         'routing' => '\TYPO3\CMS\Core\Routing\SiteRouteResult|\TYPO3\CMS\Core\Routing\PageArguments',
+        'module' => \TYPO3\CMS\Backend\Module\ModuleInterface::class,
+        'moduleData' => \TYPO3\CMS\Backend\Module\ModuleData::class,
     ]));
 
     override(\TYPO3\CMS\Core\Routing\SiteMatcher::matchRequest(), type(
@@ -136,4 +132,16 @@
         \TYPO3\CMS\Core\Routing\PageArguments::class,
         \TYPO3\CMS\Core\Routing\RouteResultInterface::class,
     ));
+
+    override(\Psr\Container\ContainerInterface::get(0), map([
+        '' => '@',
+    ]));
+
+    override(\Psr\EventDispatcher\EventDispatcherInterface::dispatch(0), map([
+        '' => '@',
+    ]));
+
+    override(\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(0), map([
+        '' => '@'
+    ]));
 }

Classes/Command/CleanupController.php

@@ -15,12 +15,14 @@ class CleanupController extends Command
     /**
      * Configure the command by defining the name, options and arguments
      */
-    protected function configure()
+    #[\Override]
+    protected function configure(): void
     {
         $this->setDescription('Removes stale _mm records and removes invalid tag_mm records pointing to wrong languages.');
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    #[\Override]
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionByName(ConnectionPool::DEFAULT_CONNECTION_NAME);
 

Classes/Command/ExportController.php

@@ -17,7 +17,8 @@ class ExportController extends Command
     /**
      * Configure the command by defining the name, options and arguments
      */
-    protected function configure()
+    #[\Override]
+    protected function configure(): void
     {
         $this
             ->setDescription('Export a given list of SkillSets to a file')
@@ -38,12 +39,9 @@ protected function configure()
 
     /**
      * Executes the command for adding the lock file
-     *
-     * @param InputInterface $input
-     * @param OutputInterface $output
-     * @return int
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    #[\Override]
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $skillSets = $input->getArgument('skillSets');
         $targetFileName = $input->getOption('output');

Classes/Command/GuestUserController.php

@@ -24,12 +24,14 @@ class GuestUserController extends Command
     /**
      * Configure the command by defining the name, options and arguments
      */
-    protected function configure()
+    #[\Override]
+    protected function configure(): void
     {
         $this->setDescription('Cleanup old guest users');
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    #[\Override]
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         (new GuestUserCleanupService())->run();
         return Command::SUCCESS;

Classes/Command/ImportController.php

@@ -18,7 +18,8 @@ class ImportController extends Command
     /**
      * Configure the command by defining the name, options and arguments
      */
-    protected function configure()
+    #[\Override]
+    protected function configure(): void
     {
         $this
             ->setDescription('Import data from json export file')
@@ -37,9 +38,9 @@ protected function configure()
                 null,
                 InputOption::VALUE_REQUIRED,
                 'Specify the mode for detected changes.'
-                . LF . ' - "ask": Ask whether to import the record'
-                . LF . ' - "ignore": Ignore all data from the import file which exist already'
-                . LF . ' - "force": Overwrite all local data with the values from the import file',
+                . "\n" . ' - "ask": Ask whether to import the record'
+                . "\n" . ' - "ignore": Ignore all data from the import file which exist already'
+                . "\n" . ' - "force": Overwrite all local data with the values from the import file',
                 'ignore'
             )
             ->addOption(
@@ -53,12 +54,9 @@ protected function configure()
 
     /**
      * Executes the command for adding the lock file
-     *
-     * @param InputInterface $input
-     * @param OutputInterface $output
-     * @return int 0 if everything went fine, or an exit code
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    #[\Override]
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $sourceFile = $input->getArgument('sourceFile');
         $pid = (int)$input->getArgument('pid');