WWSTCERT-8722/8725 [Aqara] add Aqara Wireless Remote Switch H1(Single/Double) #2511

seojune79 · 2025-10-31T04:33:01Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2025-10-31T04:33:31Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-10-31T04:35:51Z

Test Results

71 files 466 suites 0s ⏱️
2 417 tests 2 417 ✅ 0 💤 0 ❌
4 117 runs 4 117 ✅ 0 💤 0 ❌

Results for commit 7c8dab2.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-31T04:35:52Z

File	Coverage
All files	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/TRADFRI_remote_control.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/somfy/somfy_situo_4.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/heiman/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/zunzunbee/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/SLED/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/iris/init.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/pushButton/init.lua	`76%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/adurosmart/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ecosmart/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/aqara/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/supported_values.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/robb/init.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/button_utils.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/shinasystems/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/wallhero/init.lua	`88%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/vimar/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/frient/init.lua	`98%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7c8dab2

github-actions · 2025-10-31T04:45:06Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/VbMbbWqXZpMB

drivers/SmartThings/zigbee-button/profiles/aqara-double-buttons-mode.yml

drivers/SmartThings/zigbee-button/profiles/aqara-single-button-mode.yml

wkhenon · 2025-11-06T14:43:07Z

drivers/SmartThings/zigbee-button/src/test/test_aqara_button.lua

+local mock_device_h1_double_rocker = test.mock_device.build_test_zigbee_device(
  {
-    profile = t_utils.get_profile_definition("aqara-double-buttons.yml"),
+    profile = t_utils.get_profile_definition("aqara-double-buttons-mode.yml"),


If I'm understanding these testing changes correctly: The aqara-double-buttons-mode.yml profile should cover testing for the aqara-double-buttons.yml profile as well right? And the additional test was added to test the mode change for the H1 remote only?

Yes, that’s correct. Since all the code is identical except for the mode change, I used aqara-double-buttons-mode.yml.

greens

You have a failing unit test.

seojune79 · 2025-11-11T22:26:05Z

You have a failing unit test.

My test results all indicate 'Pass'. Can you provide specific details about what the problem is?

greens · 2025-11-12T20:20:48Z

From the CI for Wireless Remote Switch H1 Mode Change

TRACE || Waiting on startupState message
INFO  || received driver startupState: {"device_ids":["00000000-1111-2222-3333-000000000001","00000000-1111-2222-3333-000000000003"]}
INFO  || Starting driver[zigbee_button] with 2 device IDs
TRACE || Waiting on init messages
TRACE || Zigbee Device: 00000000-1111-2222-3333-000000000001
Manufacturer: LUMI Model: lumi.remote.acn003
	[1]: server: PowerConfiguration, 0x0012
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000001 [0x0001]> received lifecycle event: init
TRACE || Zigbee Device: 00000000-1111-2222-3333-000000000003
Manufacturer: LUMI Model: lumi.remote.b286acn03
	[1]: server: PowerConfiguration, 0x0012
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received lifecycle event: init
TRACE || Startup process completed
TRACE || Found DeviceLifecycleDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Found DeviceLifecycleDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Received event with handler zigbee
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received Zigbee message: < ZigbeeMessageRx || type: 0x00, < AddressHeader || src_addr: 0x0002, src_endpoint: 0x01, dest_addr: 0x0000, dest_endpoint: 0x01, profile: 0x0104, cluster: 0xFCC0 >, lqi: 0x00, rssi: 0, body_length: 0x0037, < ZCLMessageBody || < ZCLHeader || frame_ctrl: 0x04, mfg_code: 0x115F, seqno: 0x00, ZCLCommandId: 0x0A >, < ReportAttribute || < AttributeRecord || AttributeId: 0x00F7, DataType: OctetString, OctetString: "\x01\x21\xB8\x0B\x03\x28\x19\x04\x21\xA8\x13\x05\x21\x45\x08\x06\x24\x07\x00\x00\x00\x00\x08\x21\x15\x01\x0A\x21\xF5\x65\x0C\x20\x01\x64\x20\x01\x66\x20\x03\x67\x20\x01\x68\x21\xA8\x00" > > > >
TRACE || Found ZigbeeMessageDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Received event with handler device_lifecycle
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received lifecycle event: infoChanged
TRACE || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received unhandled lifecycle event: infoChanged
DEBUG || zigbee_button device thread event handled
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="main", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="main", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="main", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="button1", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="button1", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="button1", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="button2", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="button2", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="button2", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="all", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="all", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="all", state={value="pushed"}}}
FAILED

I expect you're not seeing the failure locally because you have not updated your local lua libraries to the latest artifact: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/releases/tag/apiv16_59

But I have not looked very deeply.

seojune79 · 2025-11-12T22:30:04Z

From the CI for Wireless Remote Switch H1 Mode Change

TRACE || Waiting on startupState message
INFO  || received driver startupState: {"device_ids":["00000000-1111-2222-3333-000000000001","00000000-1111-2222-3333-000000000003"]}
INFO  || Starting driver[zigbee_button] with 2 device IDs
TRACE || Waiting on init messages
TRACE || Zigbee Device: 00000000-1111-2222-3333-000000000001
Manufacturer: LUMI Model: lumi.remote.acn003
	[1]: server: PowerConfiguration, 0x0012
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000001 [0x0001]> received lifecycle event: init
TRACE || Zigbee Device: 00000000-1111-2222-3333-000000000003
Manufacturer: LUMI Model: lumi.remote.b286acn03
	[1]: server: PowerConfiguration, 0x0012
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received lifecycle event: init
TRACE || Startup process completed
TRACE || Found DeviceLifecycleDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Found DeviceLifecycleDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Received event with handler zigbee
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received Zigbee message: < ZigbeeMessageRx || type: 0x00, < AddressHeader || src_addr: 0x0002, src_endpoint: 0x01, dest_addr: 0x0000, dest_endpoint: 0x01, profile: 0x0104, cluster: 0xFCC0 >, lqi: 0x00, rssi: 0, body_length: 0x0037, < ZCLMessageBody || < ZCLHeader || frame_ctrl: 0x04, mfg_code: 0x115F, seqno: 0x00, ZCLCommandId: 0x0A >, < ReportAttribute || < AttributeRecord || AttributeId: 0x00F7, DataType: OctetString, OctetString: "\x01\x21\xB8\x0B\x03\x28\x19\x04\x21\xA8\x13\x05\x21\x45\x08\x06\x24\x07\x00\x00\x00\x00\x08\x21\x15\x01\x0A\x21\xF5\x65\x0C\x20\x01\x64\x20\x01\x66\x20\x03\x67\x20\x01\x68\x21\xA8\x00" > > > >
TRACE || Found ZigbeeMessageDispatcher handler in zigbee_button -> Aqara Wireless Switch Handler
DEBUG || zigbee_button device thread event handled
TRACE || Received event with handler device_lifecycle
INFO  || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received lifecycle event: infoChanged
TRACE || <ZigbeeDevice: 00000000-1111-2222-3333-000000000003 [0x0002]> received unhandled lifecycle event: infoChanged
DEBUG || zigbee_button device thread event handled
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="main", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="main", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="main", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="button1", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="button1", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="button1", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="button2", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="button2", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="button2", state={value="pushed"}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="supportedButtonValues", capability_id="button", component_id="all", state={value={"pushed", "held", "double"}}, visibility={displayed=false}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="numberOfButtons", capability_id="button", component_id="all", state={value=1}}}
capability was not sent expected message:
{"00000000-1111-2222-3333-000000000003", {attribute_id="button", capability_id="button", component_id="all", state={value="pushed"}}}
FAILED

I expect you're not seeing the failure locally because you have not updated your local lua libraries to the latest artifact: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/releases/tag/apiv16_59

But I have not looked very deeply.

I've updated to the latest library you mentioned (apiv16_59) and ran the tests. All test cases (TCs) passed successfully. Please let me know if there's anything else I need to check.

Also, I submitted my PR two weeks ago. Could you please confirm if I also need to test it against the library that was updated last week?

seojune79 · 2025-11-12T22:36:00Z

https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/releases/tag/apiv16_59

First, I'll check if the result is the same on a different PC.

greens · 2025-11-12T22:53:09Z

Maybe you need to rebase your branch, then?

seojune79 · 2025-11-12T23:25:58Z

Maybe you need to rebase your branch, then?

I've rebased.

greens requested review from greens, pegor-karoglanian and wkhenon November 4, 2025 20:58

greens changed the title ~~[Aqara] add Aqara Wireless Remote Switch H1(Single/Double)~~ WWSTCERT-8722/8725 [Aqara] add Aqara Wireless Remote Switch H1(Single/Double) Nov 4, 2025

wkhenon reviewed Nov 6, 2025

View reviewed changes

wkhenon approved these changes Nov 7, 2025

View reviewed changes

greens requested changes Nov 11, 2025

View reviewed changes

seojune79 added 2 commits November 13, 2025 08:15

add Aqara Wireless Remote Switch H1(Single/Double)

87fe0fb

remove the commented‑out code

7c8dab2

seojune79 force-pushed the Aqara-WirelessRemoteSwitchH1 branch from dc6e9c2 to 7c8dab2 Compare November 12, 2025 23:15

greens approved these changes Nov 13, 2025

View reviewed changes

WWSTCERT-8722/8725 [Aqara] add Aqara Wireless Remote Switch H1(Single/Double) #2511

Are you sure you want to change the base?

WWSTCERT-8722/8725 [Aqara] add Aqara Wireless Remote Switch H1(Single/Double) #2511

Conversation

seojune79 commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Uh oh!

Uh oh!

wkhenon Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

seojune79 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

seojune79 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greens commented Nov 12, 2025

Uh oh!

seojune79 commented Nov 12, 2025

Uh oh!

seojune79 commented Nov 12, 2025

Uh oh!

greens commented Nov 12, 2025

Uh oh!

seojune79 commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

seojune79 commented Oct 31, 2025 •

edited

Loading

github-actions bot commented Oct 31, 2025 •

edited

Loading

github-actions bot commented Oct 31, 2025 •

edited

Loading

seojune79 commented Nov 11, 2025 •

edited

Loading