fix: Hue Multi-Button Remote Inconsistencies #2533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multi-button devices, we were waiting to populate the mappings to associate the multiple button service resources to the single device record from the API responses we perform during the `init` handler. This could lead to inconsistent state or failure to maintain mappings in situations where those API calls failed for any reason. We still need to make those API calls during `init` to establish the current state of the device, but we now populate the mappings from cached data (if it exists) instead of relying on those initial API calls to resolve properly.
dljsjr
requested review from
Con-Tejus,
NoahCornell,
nickolas-deboom,
varzac and
z-michel
dljsjr
changed the title
|
Invitation URL: |
Test Results 71 files 464 suites 0s ⏱️ Results for commit 3fc413e. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3fc413e |
NoahCornell
approved these changes
Nov 6, 2025
Con-Tejus
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
For multi-button devices, we were waiting to populate the mappings to
associate the multiple button service resources to the single device
record from the API responses we perform during the
inithandler.This could lead to inconsistent state or failure to maintain mappings in
situations where those API calls failed for any reason.
We still need to make those API calls during
initto establish thecurrent state of the device, but we now populate the mappings from
cached data (if it exists) instead of relying on those initial API calls
to resolve properly.
We also relax the channel timeouts around threaded API calls to reduce the likelihood that we error out on an API call that would succeed, but is being delayed by processing/queuing delay on the ST Hub.