zb-motion: Lazy loading of can handle and scripting testing ground #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 466 suites 0s ⏱️ Results for commit 993cfb0. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 993cfb0 |
…nto sub-subdriver directories
aleclorimer
force-pushed
the
task/zigbee-motion-sensor-lazy-load-subdrivers
branch
from
0ae4dbb to
993cfb0
Compare
cjswedes
approved these changes
Nov 13, 2025
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
LGTM, just a few formatting nits that are nice to have. Did the test suite get run against 0.58 lua libs? CI is now running 0.59 lua libs, and we need to check that 58 doesnt have failing tests related to this.
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| { mfr = "AduroSmart Eria", model = "VMS_ADUROLIGHT" } | ||
| } | ||
|
|
||
| return DEVICES_REPORTING_BATTERY_VOLTAGE No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: newline at end of file
| -- Licensed under the Apache License, Version 2.0 | ||
|
|
||
| local function centralite_can_handle(opts, driver, device, ...) | ||
| if device:get_manufacturer() == "CentraLite" then |
|
|
||
| local function gatorsystem_can_handle(opts, driver, device, ...) | ||
| if device:get_manufacturer() == "GatorSystem" and device:get_model() == "GSHW01" then | ||
| return true, require("gatorsystem") |
| -- Licensed under the Apache License, Version 2.0 | ||
|
|
||
| local function samjin_can_handle(opts, driver, device, ...) | ||
| if device:get_manufacturer() == "Samjin" then |
| -- Licensed under the Apache License, Version 2.0 | ||
|
|
||
| local function smartthings_can_handle(opts, driver, device, ...) | ||
| if device:get_manufacturer() == "SmartThings" then |
greens
reviewed
Nov 13, 2025
Contributor
greens
left a comment
greens
left a comment
There was a problem hiding this comment.
While you're touching all of these files, would it be possible to replace the existing copyright/license statement with the shorter one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading of the
zigbee-motion-sensorsub drivers with thecan_handlelazy loading.This driver was modified heavily by the use of a script I've been developing to automate this process for the rest of the zigbee, zwave and matter drivers. This is the first PR & driver refactored with the assistance of the script (though still massaged to pass all driver tests by me).