Skip to content

Commit 9301688

Browse files
committed
rename [MASConstraintMaker initWithView:item:] to [MASConstraintMaker initWithLayoutGuide:]
1 parent b59824e commit 9301688

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

Masonry/LayoutGuide+MASAdditions.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,22 @@ @implementation MASLayoutGuide (MASAdditions)
1414

1515
- (NSArray *)mas_makeConstraints:(void(NS_NOESCAPE ^)(id<MASLayoutConstraint> make))block {
1616
self.owningView.translatesAutoresizingMaskIntoConstraints = NO;
17-
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithView:self.owningView item:self];
17+
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithLayoutGuide:self];
1818
block(constraintMaker);
1919
return [constraintMaker install];
2020
}
2121

2222
- (NSArray *)mas_updateConstraints:(void(NS_NOESCAPE ^)(id<MASLayoutConstraint> make))block {
2323
self.owningView.translatesAutoresizingMaskIntoConstraints = NO;
24-
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithView:self.owningView item:self];
24+
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithLayoutGuide:self];
2525
constraintMaker.updateExisting = YES;
2626
block(constraintMaker);
2727
return [constraintMaker install];
2828
}
2929

3030
- (NSArray *)mas_remakeConstraints:(void(NS_NOESCAPE ^)(id<MASLayoutConstraint> make))block {
3131
self.owningView.translatesAutoresizingMaskIntoConstraints = NO;
32-
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithView:self.owningView item:self];
32+
MASConstraintMaker *constraintMaker = [[MASConstraintMaker alloc] initWithLayoutGuide:self];
3333
constraintMaker.removeExisting = YES;
3434
block(constraintMaker);
3535
return [constraintMaker install];

Masonry/MASConstraintMaker.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ typedef NS_OPTIONS(NSInteger, MASAttribute) {
163163
*/
164164
- (id)initWithView:(MAS_VIEW *)view;
165165

166-
- (id)initWithView:(MAS_VIEW *)view item:(id)item;
166+
- (id)initWithLayoutGuide:(MASLayoutGuide *)layoutGuide API_AVAILABLE(macos(10.11), ios(9.0));
167167

168168
/**
169169
* Calls install method on any MASConstraints which have been created by this maker

Masonry/MASConstraintMaker.m

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,30 @@
1717
@interface MASConstraintMaker () <MASConstraintDelegate>
1818

1919
@property (nonatomic, weak) MAS_VIEW *view;
20-
@property (nonatomic, weak) id item;
20+
@property (nullable, nonatomic, weak) MASLayoutGuide *item;
2121
@property (nonatomic, strong) NSMutableArray *constraints;
2222

2323
@end
2424

2525
@implementation MASConstraintMaker
2626

2727
- (id)initWithView:(MAS_VIEW *)view {
28-
return [self initWithView:view item:nil];
28+
self = [super init];
29+
if (!self) return nil;
30+
31+
self.view = view;
32+
self.constraints = NSMutableArray.new;
33+
34+
return self;
2935
}
3036

31-
- (id)initWithView:(MAS_VIEW *)view item:(id)item {
37+
- (id)initWithLayoutGuide:(MASLayoutGuide *)layoutGuide {
38+
NSAssert(layoutGuide.owningView != nil, @"layoutGuide's owningView must not be nil");
3239
self = [super init];
3340
if (!self) return nil;
3441

35-
self.view = view;
36-
self.item = item;
42+
self.view = layoutGuide.owningView;
43+
self.item = layoutGuide;
3744
self.constraints = NSMutableArray.new;
3845

3946
return self;

0 commit comments

Comments
 (0)