♻️ Some refactoring and javadoc

Author: ujibang

commons/src/main/java/org/restheart/exchange/MongoRequest.java

@@ -1083,7 +1083,7 @@ public void setClientSession(ClientSessionImpl clientSession) {
     }
 
     /**
-     * @return the jsonMode as specified by jsonMode query paramter
+     * @return the jsonMode as specified by jsonMode query parameter
      */
     public JsonMode getJsonMode() {
         return jsonMode;
@@ -1179,7 +1179,7 @@ public long getRequestStartTime() {
 
     /**
      * @param dbName
-     *               Seehttps://docs.mongodb.org/v3.2/reference/limits/#naming-restrictions
+     *              See <a href="https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions">mongodb naming restrictions</a>
      * @return
      */
     public boolean isDbNameInvalid(String dbName) {
@@ -1192,7 +1192,7 @@ public boolean isDbNameInvalid(String dbName) {
                 || dbName.contains("\"")
                 || dbName.contains("$")
                 || dbName.length() > 64
-                || dbName.length() == 0);
+                || dbName.isEmpty());
     }
 
     /**
@@ -1206,7 +1206,7 @@ public boolean isDbNameInvalidOnWindows() {
 
     /**
      * @param dbName
-     *               Seehttps://docs.mongodb.org/v3.2/reference/limits/#naming-restrictions
+     *               See <a href="https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions">mongodb naming restrictions</a>
      * @return
      */
     public boolean isDbNameInvalidOnWindows(String dbName) {
@@ -1221,7 +1221,7 @@ public boolean isDbNameInvalidOnWindows(String dbName) {
     }
 
     /**
-     * See https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions
+     * See <a href="https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions">mongodb naming restrictions</a>
      *
      * @return
      */
@@ -1231,7 +1231,7 @@ public boolean isCollectionNameInvalid() {
 
     /**
      * @param collectionName
-     *                       See https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions
+     *                       See <a href="https://www.mongodb.com/docs/manual/reference/limits/#naming-restrictions">mongodb naming restrictions</a>
      * @return
      */
     public boolean isCollectionNameInvalid(String collectionName) {

mongodb/src/main/java/org/restheart/mongodb/exchange/MongoRequestPropsInjector.java

@@ -64,7 +64,7 @@ public class MongoRequestPropsInjector {
 
     /**
      *
-     * @param exchange
+     * @param exchange the exchange to inject the properties to
      */
     public static void inject(HttpServerExchange exchange) {
         var request = MongoRequest.of(exchange);
@@ -258,7 +258,7 @@ public static void inject(HttpServerExchange exchange) {
                     if (!_filter.isDocument()) {
                         response.setInError(HttpStatus.SC_BAD_REQUEST, "illegal filter parameter, it is not a json object: " + f + " => " + f.getClass().getSimpleName());
                         return true;
-                    } else if (_filter.asDocument().keySet().isEmpty()) {
+                    } else if (_filter.asDocument().isEmpty()) {
                         response.setInError(HttpStatus.SC_BAD_REQUEST, "illegal filter parameter (empty json object)");
                         return true;
                     }
@@ -288,7 +288,7 @@ public static void inject(HttpServerExchange exchange) {
         if (avars != null) {
             Optional<String> _qvars = avars.stream().findFirst();
 
-            if (!_qvars.isPresent()) {
+            if (_qvars.isEmpty()) {
                 response.setInError(HttpStatus.SC_BAD_REQUEST, "Illegal avars parameter (empty)");
                 return;
             }
@@ -386,7 +386,7 @@ public static void inject(HttpServerExchange exchange) {
                 try {
                     var _shardKeys = BsonDocument.parse(f);
 
-                    if (_shardKeys.keySet().isEmpty()) {
+                    if (_shardKeys.isEmpty()) {
                         response.setInError(HttpStatus.SC_BAD_REQUEST, "illegal shardkey parameter (empty json object)");
                         return true;
                     }