SONARMSBRU-282 Starting the Scanner without parameters should not throw exception

Author: tamasvajk

SonarQube.Bootstrapper/BootstrapperClass.cs

@@ -82,6 +82,12 @@ private int PostProcess()
             Utilities.LogAssemblyVersion(Logger, typeof(Program).Assembly, Resources.AssemblyDescription);
             Logger.IncludeTimestamp = true;
 
+            if (!Directory.Exists(BootstrapSettings.TempDirectory))
+            {
+                Logger.LogError(Resources.ERROR_TempDirDoesNotExist);
+                return ErrorCode;
+            }
+
             Directory.SetCurrentDirectory(BootstrapSettings.TempDirectory);
             ITeamBuildSettings teamBuildSettings = TeamBuildSettings.GetSettingsFromEnvironment(Logger);
             AnalysisConfig config = GetAnalysisConfig(teamBuildSettings.AnalysisConfigFilePath);

SonarQube.Bootstrapper/Resources.Designer.cs

@@ -138,6 +138,9 @@
   <data name="ERROR_ProcessingFailed" xml:space="preserve">
     <value>{0} failed. Exit code: {1}</value>
   </data>
+  <data name="ERROR_TempDirDoesNotExist" xml:space="preserve">
+    <value>Temporary analysis directory (usually .sonarqube) doesn't exist. The "begin" step was probably not executed.</value>
+  </data>
   <data name="ERROR_VersionMismatch" xml:space="preserve">
     <value>The C# plugin installed on the SonarQube server is not compatible with the SonarQube analysis agent (i.e. the MSBuild.SonarQube.Scanner.exe, or the build automation task). Either check the compatibility matrix or get the latest versions for both.</value>
   </data>

SonarQube.Bootstrapper/Resources.resx

@@ -170,6 +170,21 @@ public void Exe_PostProc_Fails()
             }
         }
 
+        [TestMethod]
+        public void Exe_PostProc_Fails_On_Missing_TempFolder()
+        {
+            Directory.Delete(TempDir, true);
+
+            using (InitializeNonTeamBuildEnvironment(RootDir))
+            {
+                // Act
+                TestLogger logger = CheckExecutionFails(AnalysisPhase.PostProcessing, false);
+
+                // Assert
+                logger.AssertErrorsLogged(2);
+            }
+        }
+
         [TestMethod]
         public void Exe_PostProc_Succeeds()
         {