From 6f372714b778a4641d764d33b8134ecdcf0776f2 Mon Sep 17 00:00:00 2001 From: Alex Meseldzija Date: Wed, 5 Nov 2025 14:31:09 +0100 Subject: [PATCH 1/3] Add CSharp.SDK.9 IT --- its/projects/CSharp.SDK.9/CSharp.SDK.9.sln | 31 +++++++++++++++++++++ its/projects/CSharp.SDK.9/Main/Common.cs | 8 ++++++ its/projects/CSharp.SDK.9/Main/Main.csproj | 8 ++++++ its/projects/CSharp.SDK.9/UTs/CommonTest.cs | 16 +++++++++++ its/projects/CSharp.SDK.9/UTs/UTs.csproj | 23 +++++++++++++++ its/projects/CSharp.SDK.9/global.json | 6 ++++ 6 files changed, 92 insertions(+) create mode 100644 its/projects/CSharp.SDK.9/CSharp.SDK.9.sln create mode 100644 its/projects/CSharp.SDK.9/Main/Common.cs create mode 100644 its/projects/CSharp.SDK.9/Main/Main.csproj create mode 100644 its/projects/CSharp.SDK.9/UTs/CommonTest.cs create mode 100644 its/projects/CSharp.SDK.9/UTs/UTs.csproj create mode 100644 its/projects/CSharp.SDK.9/global.json diff --git a/its/projects/CSharp.SDK.9/CSharp.SDK.9.sln b/its/projects/CSharp.SDK.9/CSharp.SDK.9.sln new file mode 100644 index 0000000000..ba358081f8 --- /dev/null +++ b/its/projects/CSharp.SDK.9/CSharp.SDK.9.sln @@ -0,0 +1,31 @@ + +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 17 +VisualStudioVersion = 17.4.33015.44 +MinimumVisualStudioVersion = 10.0.40219.1 +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Main", "Main\Main.csproj", "{FC4653F8-668E-4C37-BDE3-AF03814B716E}" +EndProject +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "UTs", "UTs\UTs.csproj", "{E96549B1-F7A1-421B-A81C-8547BB101407}" +EndProject +Global + GlobalSection(SolutionConfigurationPlatforms) = preSolution + Debug|Any CPU = Debug|Any CPU + Release|Any CPU = Release|Any CPU + EndGlobalSection + GlobalSection(ProjectConfigurationPlatforms) = postSolution + {FC4653F8-668E-4C37-BDE3-AF03814B716E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {FC4653F8-668E-4C37-BDE3-AF03814B716E}.Debug|Any CPU.Build.0 = Debug|Any CPU + {FC4653F8-668E-4C37-BDE3-AF03814B716E}.Release|Any CPU.ActiveCfg = Release|Any CPU + {FC4653F8-668E-4C37-BDE3-AF03814B716E}.Release|Any CPU.Build.0 = Release|Any CPU + {E96549B1-F7A1-421B-A81C-8547BB101407}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {E96549B1-F7A1-421B-A81C-8547BB101407}.Debug|Any CPU.Build.0 = Debug|Any CPU + {E96549B1-F7A1-421B-A81C-8547BB101407}.Release|Any CPU.ActiveCfg = Release|Any CPU + {E96549B1-F7A1-421B-A81C-8547BB101407}.Release|Any CPU.Build.0 = Release|Any CPU + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE + EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {4B548A8F-F688-4D3A-ACA4-B440513094F3} + EndGlobalSection +EndGlobal diff --git a/its/projects/CSharp.SDK.9/Main/Common.cs b/its/projects/CSharp.SDK.9/Main/Common.cs new file mode 100644 index 0000000000..a0da105fb6 --- /dev/null +++ b/its/projects/CSharp.SDK.9/Main/Common.cs @@ -0,0 +1,8 @@ +namespace CSharp.SDKs +{ + public static class Common + { + // FIXME: This line contains S1134 warning + public static bool IsGreaterThanZero(int value) => value > 0; + } +} diff --git a/its/projects/CSharp.SDK.9/Main/Main.csproj b/its/projects/CSharp.SDK.9/Main/Main.csproj new file mode 100644 index 0000000000..f6026fa536 --- /dev/null +++ b/its/projects/CSharp.SDK.9/Main/Main.csproj @@ -0,0 +1,8 @@ + + + net9.0 + + + false + + diff --git a/its/projects/CSharp.SDK.9/UTs/CommonTest.cs b/its/projects/CSharp.SDK.9/UTs/CommonTest.cs new file mode 100644 index 0000000000..d24f52ffe8 --- /dev/null +++ b/its/projects/CSharp.SDK.9/UTs/CommonTest.cs @@ -0,0 +1,16 @@ +using Microsoft.VisualStudio.TestTools.UnitTesting; + +namespace CSharp.SDKs.Test +{ + [TestClass] + public class CommonTest + { + // FIXME: This line contains S1134 warning in SL, but not in S4NET context due to current test-code support + + [TestMethod] + public void TestMethodWithNoAssertion() // S2699: Add at least one assertion to this test case. This rule has test-only scope. + { + Common.IsGreaterThanZero(1); + } + } +} diff --git a/its/projects/CSharp.SDK.9/UTs/UTs.csproj b/its/projects/CSharp.SDK.9/UTs/UTs.csproj new file mode 100644 index 0000000000..0b508bfdfb --- /dev/null +++ b/its/projects/CSharp.SDK.9/UTs/UTs.csproj @@ -0,0 +1,23 @@ + + + net9.0 + + + false + + + + + + + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + + + + + + + + diff --git a/its/projects/CSharp.SDK.9/global.json b/its/projects/CSharp.SDK.9/global.json new file mode 100644 index 0000000000..66690f8397 --- /dev/null +++ b/its/projects/CSharp.SDK.9/global.json @@ -0,0 +1,6 @@ +{ + "sdk": { + "version": "9.0.0", + "rollForward": "latestFeature" + } +} From a7d060e5ac7504a6d64c75a922e7bd1fdb7c6db2 Mon Sep 17 00:00:00 2001 From: Alex Meseldzija Date: Wed, 5 Nov 2025 14:31:17 +0100 Subject: [PATCH 2/3] Add test --- .../it/scanner/msbuild/sonarqube/SolutionKindTest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/SolutionKindTest.java b/its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/SolutionKindTest.java index f8c4e2f54f..7a35dfc367 100644 --- a/its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/SolutionKindTest.java +++ b/its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/SolutionKindTest.java @@ -165,6 +165,13 @@ void sdk8() { @Test // dotnet sdk tests should run only on VS 2022 and above @MSBuildMinVersion(17) + void sdk9() { + validateCSharpSdk("CSharp.SDK.9"); + } + + @Test + // dotnet sdk tests should run only on VS 2022 + @MSBuildMinVersion(17) void net8_NoAnalysisWarnings() { var context = AnalysisContext.forServer("CSharp.SDK.8"); var result = context.runAnalysis(); From 567fde89ea5903062a568040ab240308a3fd74bc Mon Sep 17 00:00:00 2001 From: Alex Meseldzija Date: Thu, 6 Nov 2025 17:06:40 +0100 Subject: [PATCH 3/3] Review01 --- its/projects/CSharp.SDK.8/Main/Common.cs | 8 -------- its/projects/CSharp.SDK.8/Main/Main.csproj | 6 ++++++ its/projects/CSharp.SDK.8/UTs/CommonTest.cs | 16 ---------------- its/projects/CSharp.SDK.8/UTs/UTs.csproj | 11 ++++++----- its/projects/CSharp.SDK.9/Main/Common.cs | 8 -------- its/projects/CSharp.SDK.9/Main/Main.csproj | 6 ++++++ its/projects/CSharp.SDK.9/UTs/CommonTest.cs | 16 ---------------- its/projects/CSharp.SDK.9/UTs/UTs.csproj | 11 ++++++----- 8 files changed, 24 insertions(+), 58 deletions(-) delete mode 100644 its/projects/CSharp.SDK.8/Main/Common.cs delete mode 100644 its/projects/CSharp.SDK.8/UTs/CommonTest.cs delete mode 100644 its/projects/CSharp.SDK.9/Main/Common.cs delete mode 100644 its/projects/CSharp.SDK.9/UTs/CommonTest.cs diff --git a/its/projects/CSharp.SDK.8/Main/Common.cs b/its/projects/CSharp.SDK.8/Main/Common.cs deleted file mode 100644 index a0da105fb6..0000000000 --- a/its/projects/CSharp.SDK.8/Main/Common.cs +++ /dev/null @@ -1,8 +0,0 @@ -namespace CSharp.SDKs -{ - public static class Common - { - // FIXME: This line contains S1134 warning - public static bool IsGreaterThanZero(int value) => value > 0; - } -} diff --git a/its/projects/CSharp.SDK.8/Main/Main.csproj b/its/projects/CSharp.SDK.8/Main/Main.csproj index 1928992a41..fa542fd5d4 100644 --- a/its/projects/CSharp.SDK.8/Main/Main.csproj +++ b/its/projects/CSharp.SDK.8/Main/Main.csproj @@ -5,4 +5,10 @@ false + + + + Common.cs + + diff --git a/its/projects/CSharp.SDK.8/UTs/CommonTest.cs b/its/projects/CSharp.SDK.8/UTs/CommonTest.cs deleted file mode 100644 index d24f52ffe8..0000000000 --- a/its/projects/CSharp.SDK.8/UTs/CommonTest.cs +++ /dev/null @@ -1,16 +0,0 @@ -using Microsoft.VisualStudio.TestTools.UnitTesting; - -namespace CSharp.SDKs.Test -{ - [TestClass] - public class CommonTest - { - // FIXME: This line contains S1134 warning in SL, but not in S4NET context due to current test-code support - - [TestMethod] - public void TestMethodWithNoAssertion() // S2699: Add at least one assertion to this test case. This rule has test-only scope. - { - Common.IsGreaterThanZero(1); - } - } -} diff --git a/its/projects/CSharp.SDK.8/UTs/UTs.csproj b/its/projects/CSharp.SDK.8/UTs/UTs.csproj index 51720bef2c..d5820db406 100644 --- a/its/projects/CSharp.SDK.8/UTs/UTs.csproj +++ b/its/projects/CSharp.SDK.8/UTs/UTs.csproj @@ -7,17 +7,18 @@ - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - + + + + CommonTest.cs + + diff --git a/its/projects/CSharp.SDK.9/Main/Common.cs b/its/projects/CSharp.SDK.9/Main/Common.cs deleted file mode 100644 index a0da105fb6..0000000000 --- a/its/projects/CSharp.SDK.9/Main/Common.cs +++ /dev/null @@ -1,8 +0,0 @@ -namespace CSharp.SDKs -{ - public static class Common - { - // FIXME: This line contains S1134 warning - public static bool IsGreaterThanZero(int value) => value > 0; - } -} diff --git a/its/projects/CSharp.SDK.9/Main/Main.csproj b/its/projects/CSharp.SDK.9/Main/Main.csproj index f6026fa536..338f184c16 100644 --- a/its/projects/CSharp.SDK.9/Main/Main.csproj +++ b/its/projects/CSharp.SDK.9/Main/Main.csproj @@ -5,4 +5,10 @@ false + + + + Common.cs + + diff --git a/its/projects/CSharp.SDK.9/UTs/CommonTest.cs b/its/projects/CSharp.SDK.9/UTs/CommonTest.cs deleted file mode 100644 index d24f52ffe8..0000000000 --- a/its/projects/CSharp.SDK.9/UTs/CommonTest.cs +++ /dev/null @@ -1,16 +0,0 @@ -using Microsoft.VisualStudio.TestTools.UnitTesting; - -namespace CSharp.SDKs.Test -{ - [TestClass] - public class CommonTest - { - // FIXME: This line contains S1134 warning in SL, but not in S4NET context due to current test-code support - - [TestMethod] - public void TestMethodWithNoAssertion() // S2699: Add at least one assertion to this test case. This rule has test-only scope. - { - Common.IsGreaterThanZero(1); - } - } -} diff --git a/its/projects/CSharp.SDK.9/UTs/UTs.csproj b/its/projects/CSharp.SDK.9/UTs/UTs.csproj index 0b508bfdfb..ba9a58edb4 100644 --- a/its/projects/CSharp.SDK.9/UTs/UTs.csproj +++ b/its/projects/CSharp.SDK.9/UTs/UTs.csproj @@ -7,17 +7,18 @@ - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - + + + CommonTest.cs + + +