Skip to content

Kafka 1.0 support? #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coltfred opened this issue Nov 3, 2017 · 2 comments
Open

Kafka 1.0 support? #9

coltfred opened this issue Nov 3, 2017 · 2 comments

Comments

@coltfred
Copy link
Contributor

coltfred commented Nov 3, 2017

I'm still fairly new to this library, but Kafka released 1.0 this week. After doing #8 is there anything that needs to be done to support the 1.0 protocol? Is there anything to be gained? Should we at least test against it so we have something to say? Really I'm just looking for guidance here as a newcomer.
@pchlupacek
Copy link
Member

@coltfred I believe the 1.0 will be backward compatible. You perhaps may just add this to the testcase and you will see if that works.

@AdamChlupacek
Copy link
Member

@coltfred @pchlupacek Added testcases for kafka 0.11 and 1.0.0 in #16, they all pass with the protocol for 0.10. That seems to be enough for now. We can add first class support for 1.0.0 protocol to protocols if we really need to, but since the test pass I dont see a reason to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coltfred @pchlupacek @AdamChlupacek