Plugin update checking fixes and UI improvements #816
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
-2 fixes related to plugin update checking and ui update indicators not getting refreshed correctly.
-UI improvement
Fixes
-First thing is that plugin update checking would not be run if relevant plugin had state change. (ex freeze/ unfreeze changes or plugin installed/uinstalled with plugins that had updates).
The fix simply ensures update checker is run if changes happen.
-Second issue is if any plugin had invalid semver version syntax during update checks it would fail with silent error preventing ui from ever getting updated.
The fix validates the version syntax before comparing versions and bypasses if it fails.
UI
Lastly list elements that have multiple horizontal focusable elements now retain x position
ie
Whichever columns is focused will remain focused when navigating up and down.
This change is applied to store, plugin settings and testing pr lists.