Skip to content

Commit d2610dd

Browse files
committed
making k8sattribute processor default for logs and metrics
1 parent 1c2d7a1 commit d2610dd

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

.changelog/3976.changed.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
change: use upstream k8sattributeprocessor as default for logs and metrics

deploy/helm/sumologic/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
464464
| `metadata.metrics.enabled` | Flag to control deploying the otelcol metrics statefulsets. | `true` |
465465
| `metadata.metrics.logLevel` | Flag to control logging level for OpenTelemetry Collector for metrics. Can be `debug`, `info`, `warn`, `error`, `dpanic`, `panic`, `fatal`. | `info` |
466466
| `metadata.metrics.metricsLevel` | Metrics level for the OpenTelemetry Collector. Can be `basic`, `normal`, `detailed`. | `normal` |
467-
| `metadata.metrics.useSumoK8sProcessor` | Use the SumoLogic K8s processor | `true` |
467+
| `metadata.metrics.useSumoK8sProcessor` | Use the SumoLogic K8s processor | `false` |
468468
| `metadata.metrics.waitForMetadata` | Wait for Metadata before processing the data | `true` |
469469
| `metadata.metrics.waitForMetadataTimeout` | Wait for Metadata timeout | `10s` |
470470
| `metadata.metrics.config.merge` | Configuration for metrics metadata otelcol, merged with defaults. See also https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/configuration.md. | {} |
@@ -497,7 +497,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
497497
| `metadata.logs.enabled` | Flag to control deploying the otelcol logs statefulsets. | `true` |
498498
| `metadata.logs.logLevel` | Flag to control logging level for OpenTelemetry Collector for logs. Can be `debug`, `info`, `warn`, `error`, `dpanic`, `panic`, `fatal`. | `info` |
499499
| `metadata.logs.metricsLevel` | Metrics level for the OpenTelemetry Collector. Can be `basic`, `normal`, `detailed`. | `normal` |
500-
| `metadata.logs.useSumoK8sProcessor` | Use the SumoLogic K8s processor | `true` |
500+
| `metadata.logs.useSumoK8sProcessor` | Use the SumoLogic K8s processor | `false` |
501501
| `metadata.logs.waitForMetadata` | Wait for Metadata before processing the logs | `true` |
502502
| `metadata.logs.waitForMetadataTimeout` | Wait for Metadata timeout | `10s` |
503503
| `metadata.logs.config.merge` | Configuration for logs metadata otelcol, merged with defaults. See also https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/configuration.md. | {} |

deploy/helm/sumologic/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1603,7 +1603,7 @@ metadata:
16031603

16041604
## Use the sumologic k8s processor to add metadata to the logs.
16051605
## This is enabled by default, but can be disabled if you want to use the upstream processor.
1606-
useSumoK8sProcessor: true
1606+
useSumoK8sProcessor: false
16071607

16081608
## Only used if useSumoK8sProcessor is set to false
16091609
waitForMetadata: true
@@ -1720,7 +1720,7 @@ metadata:
17201720

17211721
## Use the sumologic k8s processor to add metadata to the logs.
17221722
## This is enabled by default, but can be disabled if you want to use the upstream processor.
1723-
useSumoK8sProcessor: true
1723+
useSumoK8sProcessor: false
17241724

17251725
## Only used if useSumoK8sProcessor is set to false
17261726
waitForMetadata: true

docs/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,9 @@ The following table displays the currently used software versions for our Helm c
119119

120120
The
121121
[k8sattributesprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/k8sattributesprocessor/README.md)
122-
is now supported for logs and metrics metadata enrichment. This processor is disabled by default. To enable this processor for logs, set
123-
`metadata.logs.useSumoK8sProcessor` to `false`. To enable this processor for metrics, set `metadata.metrics.useSumoK8sProcessor` to `false`.
122+
is now supported for logs and metrics metadata enrichment. This processor is enabled by default. To disable this processor for logs, set
123+
`metadata.logs.useSumoK8sProcessor` to `true`. To disable this processor for metrics, set `metadata.metrics.useSumoK8sProcessor` to `true`.
124+
If disabled then SumoK8sProcessor will be the default automatically.
124125

125126
> [!NOTE] The Service name isn't part of the metadata enrichment with this new processor.
126127

0 commit comments

Comments
 (0)