🚑 Only log status when all relevant fields have been updated + make moderation_notes nullable again (#3160)

Author: HerrLevin

app/Http/Controllers/Frontend/Admin/StatusEditController.php

@@ -106,8 +106,9 @@ public function edit(Request $request): RedirectResponse {
         StatusUpdateEvent::dispatch($status->refresh());
 
         $payload = [
-            'visibility' => $validated['visibility'],
-            'event_id'   => $validated['event_id'],
+            'visibility'       => $validated['visibility'],
+            'event_id'         => $validated['event_id'],
+            'moderation_notes' => null,
         ];
 
         if ($status->body !== $validated['body']) {

app/Models/Status.php

@@ -45,13 +45,13 @@ class Status extends Model
 
     use HasFactory, LogsActivity;
 
-    protected $fillable = [
+    protected              $fillable     = [
         'user_id', 'body', 'business', 'visibility', 'event_id', 'mastodon_post_id', 'client_id',
         'moderation_notes', 'lock_visibility', 'hide_body',
     ];
-    protected $hidden   = ['user_id', 'business'];
-    protected $appends  = ['favorited', 'statusInvisibleToMe', 'description'];
-    protected $casts    = [
+    protected              $hidden       = ['user_id', 'business'];
+    protected              $appends      = ['favorited', 'statusInvisibleToMe', 'description'];
+    protected              $casts        = [
         'id'               => 'integer',
         'user_id'          => 'integer',
         'business'         => Business::class,
@@ -63,6 +63,7 @@ class Status extends Model
         'lock_visibility'  => 'boolean',
         'hide_body'        => 'boolean'
     ];
+    protected static array $recordEvents = ['updated'];
 
     public function user(): BelongsTo {
         return $this->belongsTo(User::class);
@@ -130,6 +131,9 @@ public function getStatusInvisibleToMeAttribute(): bool {
     }
 
     public function getActivitylogOptions(): LogOptions {
-        return LogOptions::defaults()->logOnly(['moderation_notes', 'lock_visibility', 'hide_body']);
+        return LogOptions::defaults()
+                         ->logOnly(['moderation_notes', 'lock_visibility', 'hide_body'])
+                         ->logOnlyDirty()
+                         ->dontSubmitEmptyLogs();
     }
 }