Skip to content

Commit 87cabdb

Browse files
authored
fix(middleware-code-coverage): incomplete string escaping or encoding (#194)
JIRA: CPOUI5FOUNDATION-728
1 parent 597ac76 commit 87cabdb

File tree

1 file changed

+7
-3
lines changed
  • packages/middleware-code-coverage/lib

1 file changed

+7
-3
lines changed

packages/middleware-code-coverage/lib/util.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,14 @@ async function excludePatterns(resources) {
178178
if (sPattern.endsWith("**")) {
179179
sPattern = sPattern + "/*";
180180
}
181+
181182
// quote characters that might have been used but have a special meaning in regular expressions
182-
// TODO: clarify is this regex is valid
183-
// eslint-disable-next-line no-useless-escape
184-
sPattern = sPattern.replace(/[\[\]\(\)\.]/g, "\\$&");
183+
sPattern = sPattern
184+
.replaceAll("[", "\\[")
185+
.replaceAll("]", "\\]")
186+
.replaceAll("(", "\\(")
187+
.replaceAll(")", "\\)")
188+
.replaceAll(".", "\\.");
185189
// our wildcard '*' means 'any name segment, but not multiple components'
186190
sPattern = sPattern.replace(/\*/g, "[^/]*");
187191
// our wildcard '**/' means 'any number of name segments'

0 commit comments

Comments
 (0)