Skip to content

Conversation

@dimovpetar
Copy link
Member

No description provided.

@dimovpetar dimovpetar marked this pull request as draft October 21, 2025 11:50
@dimovpetar dimovpetar force-pushed the feat_run_manifest_validation branch 4 times, most recently from c0f9c6b to 85d48a7 Compare October 28, 2025 13:56
@dimovpetar dimovpetar force-pushed the feat_run_manifest_validation branch 2 times, most recently from 9ee721e to b1ed71b Compare October 30, 2025 08:30
@coveralls
Copy link

coveralls commented Oct 30, 2025

Pull Request Test Coverage Report for Build 19231440200

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 104 of 110 (94.55%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 81.841%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/ui5Manifest.ts 46 48 95.83%
src/tools/run_manifest_validation/runValidation.ts 48 52 92.31%
Totals Coverage Status
Change from base Build 19030937854: 0.5%
Covered Lines: 1105
Relevant Lines: 1253

💛 - Coveralls

@dimovpetar dimovpetar marked this pull request as ready for review October 30, 2025 14:16
@alexandar-mitsev
Copy link
Member

Looks good to me

@dimovpetar dimovpetar force-pushed the feat_run_manifest_validation branch from 6ee3a30 to 0f4d9df Compare November 3, 2025 12:11
Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • now I often get "The MCP validation tool timed out". Seems that it happens mainly if I ask to validate a manifest, complete the task, then edit the manifest and ask to validate again.
    Maybe it is related to the mutex log and cache. Or to the ajv tool itself
    If I restart VS code, the tool can run again without a timeout. Also it runs smoothly couple of times in the same task. But fails with timeout if it runs in two different tasks in the same window.

  • every time when I validate manifest _version: "1.60.0" - I get an error
    Error:
    Failed to create UI5 manifest validate function: items value must be ["object","boolean"]

  • some older manifests are in the mapping, but have no tag for them, e.g. 1.50.0, 1.45.0
    we should think of how to improve the tool to handle this. Maybe suggest an upgrade in that case as well?

  • there are many logs for format "uri" ignored and format "uri-reference" ignored in the console, but this is not an error. Can be resolved with later update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants