Fix BinaryView::GetRelocationsAt C++ API

D0ntPanic · D0ntPanic · commit 69b6b8a0853a · 2024-01-08T15:16:06.000-07:00
diff --git a/binaryview.cpp b/binaryview.cpp
@@ -1611,7 +1611,8 @@ std::vector<Ref<Relocation>> BinaryView::GetRelocationsAt(uint64_t addr) const
 {
 	size_t count = 0;
 	BNRelocation** relocations = BNGetRelocationsAt(m_object, addr, &count);
-	std::vector<Ref<Relocation>> result(count);
+	std::vector<Ref<Relocation>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new Relocation(relocations[i]));

Original file line number	Diff line number	Diff line change
`@@ -1611,7 +1611,8 @@ std::vector<Ref<Relocation>> BinaryView::GetRelocationsAt(uint64_t addr) const`
`1611`	`1611`	`{`
`1612`	`1612`	`size_t count = 0;`
`1613`	`1613`	`BNRelocation** relocations = BNGetRelocationsAt(m_object, addr, &count);`
`1614`		`- std::vector<Ref<Relocation>> result(count);`
	`1614`	`+ std::vector<Ref<Relocation>> result;`
	`1615`	`+ result.reserve(count);`
`1615`	`1616`	`for (size_t i = 0; i < count; i++)`
`1616`	`1617`	`{`
`1617`	`1618`	`result.push_back(new Relocation(relocations[i]));`