Misc clippy lints

Author: emesare

rust/src/headless.rs

@@ -255,10 +255,10 @@ impl MainThreadHandler for HeadlessMainThreadSender {
 }
 
 fn is_enterprise_product() -> bool {
-    match crate::product().as_str() {
-        "Binary Ninja Enterprise Client" | "Binary Ninja Ultimate" => true,
-        _ => false,
-    }
+    matches!(
+        crate::product().as_str(),
+        "Binary Ninja Enterprise Client" | "Binary Ninja Ultimate"
+    )
 }
 
 #[derive(Debug, PartialEq, Eq, Clone, Copy, Hash)]

rust/src/project/folder.rs

@@ -93,17 +93,14 @@ impl ProjectFolder {
         P: ProgressCallback,
     {
         let dest_raw = dest.to_cstr();
-
-        let success = unsafe {
+        unsafe {
             BNProjectFolderExport(
                 self.handle.as_ptr(),
                 dest_raw.as_ptr(),
                 &mut progress as *mut P as *mut c_void,
                 Some(P::cb_progress_callback),
             )
-        };
-
-        success
+        }
     }
 }
 

rust/src/string.rs

@@ -191,7 +191,7 @@ pub unsafe trait AsCStr {
     fn to_cstr(self) -> Self::Result;
 }
 
-unsafe impl<'a> AsCStr for &'a CStr {
+unsafe impl AsCStr for &CStr {
     type Result = Self;
 
     fn to_cstr(self) -> Self::Result {

rust/src/type_archive.rs

@@ -250,8 +250,7 @@ impl TypeArchive {
     /// Delete an existing type in the type archive.
     pub fn delete_type_by_id<S: AsCStr>(&self, id: S) -> bool {
         let id = id.to_cstr();
-        let result = unsafe { BNDeleteTypeArchiveType(self.handle.as_ptr(), id.as_ptr()) };
-        result
+        unsafe { BNDeleteTypeArchiveType(self.handle.as_ptr(), id.as_ptr()) }
     }
 
     /// Retrieve a stored type in the archive